summaryrefslogtreecommitdiffstats
path: root/configure
diff options
context:
space:
mode:
authorOswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>2016-08-23 14:22:19 +0200
committerOswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>2016-08-25 11:56:45 +0000
commitd76a756b03840ef9339ecc30f16e8580c7f323ea (patch)
tree44be6418b643e6492621199e647f94c14a3071df /configure
parent12bb328bb0be8efe54aae750c21938aab4d17539 (diff)
clean up qconfig/qmodule.pri handling in configure
instead of saving the files away and restoring them afterwards, use the new and shiny discard_from() function to throw away everything the files might contain. strictly speaking, this is not precise, as the pris may also use *=, -=, and possibly other operations which cannot be trivially undone, but the purpose is essentially to discard the special outputs of some features which may affect subsequent tests, for which this is sufficient. as a side effect, the failure to load qmodule.pri is not fatal any more (like for qconfig.pri), to save the pointless effort of ensuring that it exists. Change-Id: I07625b60c4f2e27b21206b2c16d24ab111737395 Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure19
1 files changed, 0 insertions, 19 deletions
diff --git a/configure b/configure
index ac68f3ce4b..9ab3834cf8 100755
--- a/configure
+++ b/configure
@@ -1886,14 +1886,6 @@ config.input.qt_licheck = $Licheck
config.input.qt_release_date = $ReleaseDate
EOF
-# create a clean qmodule/qconfig.pri for running the tests
-# .qmake.cache loads qt_build_parts which requires that qmodule.pri exists
-for arg in qconfig qmodule; do
- file="$outpath/mkspecs/$arg.pri"
- [ ! -f "$file.old" ] && [ -f "$file" ] && mv "$file" "$file.old"
- : > "$file"
-done
-
# recreate command line for qmake
set -f
SAVED_IFS=$IFS
@@ -1909,17 +1901,6 @@ IFS=$SAVED_IFS
$CFG_QMAKE_PATH -o Makefile.cfg -qtconf "$QTCONFFILE" $relpath/configure.pri -- "$@" || exit 101
rm Makefile.cfg
-# Re-use old file if unchanged, to avoid needless rebuilds
-for arg in qconfig qmodule; do
- file="$outpath/mkspecs/$arg.pri"
- if cmp -s "$file" "$file.old"; then
- rm -f "$file"
- mv "$file.old" "$file"
- else
- rm -f "$file.old"
- fi
-done
-
#-------------------------------------------------------------------------------
# give feedback on configuration
#-------------------------------------------------------------------------------