diff options
author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-12-19 15:22:51 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-12-20 06:17:42 +0100 |
commit | 85a77cd5c8f4a9a2e71676ff7b600ba891983115 (patch) | |
tree | 42757b4bcd9b8f9702e11fbf70e8ad573d49d1b2 /dist | |
parent | 1749fef3c5c1dda98c6ea32e0ac17202892fc9fe (diff) |
Retire QTest::pixmapsAreEqual().
QTest::pixmapsAreEqual() was left in the Qt4 API for compatibility with
some old tests written for Qt3. QCOMPARE() is the preferred way to
compare QPixmaps and provides superior diagnostic output when a
comparison fails.
This commit removes QTest::pixmapsAreEqual() from the testlib API and
replaces the last few remaining calls with QCOMPARE.
Change-Id: I051c0e7d3bda072855fcd262d82e8e540619233b
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Diffstat (limited to 'dist')
-rw-r--r-- | dist/changes-5.0.0 | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/dist/changes-5.0.0 b/dist/changes-5.0.0 index fe159c4ad9..159ef73341 100644 --- a/dist/changes-5.0.0 +++ b/dist/changes-5.0.0 @@ -57,6 +57,9 @@ information about a particular change. internal testlib function that was exposed in the public API due to its use in a public macro. Any calls to this function should be replaced by a call to qsnprintf(), which comes from the <QtCore/QByteArray> header. + * The QTest::pixmapsAreEqual() function has been removed from the API. + Comparison of QPixmap objects should be done using QCOMPARE, which provides + more informative output in the event of a failure. * The QSKIP macro no longer has the "mode" parameter, which caused problems for calculating test metrics, as the SkipAll mode hid information about what test data was skipped. Calling QSKIP in a test function now behaves |