diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2012-04-20 16:50:36 +0200 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2012-04-28 19:42:51 +0200 |
| commit | 75a0c7f9b52cde47f20fdc1b89e1264d60350848 (patch) | |
| tree | f8869a328f2205bd9027b0580f49f3cf9bd60a85 /dist | |
| parent | 00b961c37f82977615ab9c4d03e185229cc55154 (diff) | |
[SIC] Make non-const the QRegExp methods that modify the internals
These methods modify QRegExp internals and should not have been
const. It's actually dangerous to have them const, since users may
think it's safe to use the matching method in a thread-safe manner.
Task-number: QTBUG-25064
Change-Id: Ia370eb42fd0407a94924f420297c5e83d3908214
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Diffstat (limited to 'dist')
| -rw-r--r-- | dist/changes-5.0.0 | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/dist/changes-5.0.0 b/dist/changes-5.0.0 index f4865da87b..9610cc1878 100644 --- a/dist/changes-5.0.0 +++ b/dist/changes-5.0.0 @@ -347,6 +347,13 @@ QtCore QRegularExpressionMatchIterator. They aim to replace QRegExp with a more powerful and flexible regular expression engine. +* Certain methods in QRegExp that modified the object's internals are no longer marked + const. They were accidentally marked const in Qt 4 but the problem could not be + fixed. The following are suggestions to adapt code to this change: + - make sure the QRegExp object is not const in the given context + - create a copy of the QRegExp object before using it + - invert the operation and use QString. E.g., rx.indexIn(string) becomes string.indexOf(rx) + * QEvent::AccessibilityPrepare, AccessibilityHelp and AccessibilityDescription removed: * The enum values simply didn't make sense in the first place and should simply be dropped. |