diff options
author | Tobias Hunger <tobias.hunger@qt.io> | 2019-04-16 16:32:08 +0200 |
---|---|---|
committer | Tobias Hunger <tobias.hunger@qt.io> | 2019-04-16 16:32:08 +0200 |
commit | 6630937e63ae5797487b86743a7733c8ae5cc42c (patch) | |
tree | 3d53dacf6430f9099e1fb20835881205de674961 /examples/network/network-chat | |
parent | 37ed6dae00640f9cc980ffda05347c12a7eb5d7e (diff) | |
parent | c7af193d2e49e9f10b86262e63d8d13abf72b5cf (diff) |
Merge commit 'dev' into 'wip/cmake-merge'
Change-Id: I176c40d031be26a1dd1cf08843e448a660598783
Diffstat (limited to 'examples/network/network-chat')
-rw-r--r-- | examples/network/network-chat/client.cpp | 7 | ||||
-rw-r--r-- | examples/network/network-chat/peermanager.cpp | 12 | ||||
-rw-r--r-- | examples/network/network-chat/peermanager.h | 2 |
3 files changed, 11 insertions, 10 deletions
diff --git a/examples/network/network-chat/client.cpp b/examples/network/network-chat/client.cpp index 97c2c44b6b..b76ef18238 100644 --- a/examples/network/network-chat/client.cpp +++ b/examples/network/network-chat/client.cpp @@ -71,8 +71,7 @@ void Client::sendMessage(const QString &message) if (message.isEmpty()) return; - QList<Connection *> connections = peers.values(); - foreach (Connection *connection, connections) + for (Connection *connection : qAsConst(peers)) connection->sendMessage(message); } @@ -90,8 +89,8 @@ bool Client::hasConnection(const QHostAddress &senderIp, int senderPort) const if (!peers.contains(senderIp)) return false; - QList<Connection *> connections = peers.values(senderIp); - foreach (Connection *connection, connections) { + const QList<Connection *> connections = peers.values(senderIp); + for (const Connection *connection : connections) { if (connection->peerPort() == senderPort) return true; } diff --git a/examples/network/network-chat/peermanager.cpp b/examples/network/network-chat/peermanager.cpp index 38fa2e8e50..5c48edb1b9 100644 --- a/examples/network/network-chat/peermanager.cpp +++ b/examples/network/network-chat/peermanager.cpp @@ -104,9 +104,9 @@ void PeerManager::startBroadcasting() broadcastTimer.start(); } -bool PeerManager::isLocalHostAddress(const QHostAddress &address) +bool PeerManager::isLocalHostAddress(const QHostAddress &address) const { - foreach (QHostAddress localAddress, ipAddresses) { + for (const QHostAddress &localAddress : ipAddresses) { if (address.isEqual(localAddress)) return true; } @@ -125,7 +125,7 @@ void PeerManager::sendBroadcastDatagram() } bool validBroadcastAddresses = true; - foreach (QHostAddress address, broadcastAddresses) { + for (const QHostAddress &address : qAsConst(broadcastAddresses)) { if (broadcastSocket.writeDatagram(datagram, address, broadcastPort) == -1) validBroadcastAddresses = false; @@ -182,8 +182,10 @@ void PeerManager::updateAddresses() { broadcastAddresses.clear(); ipAddresses.clear(); - foreach (QNetworkInterface interface, QNetworkInterface::allInterfaces()) { - foreach (QNetworkAddressEntry entry, interface.addressEntries()) { + const QList<QNetworkInterface> interfaces = QNetworkInterface::allInterfaces(); + for (const QNetworkInterface &interface : interfaces) { + const QList<QNetworkAddressEntry> entries = interface.addressEntries(); + for (const QNetworkAddressEntry &entry : entries) { QHostAddress broadcastAddress = entry.broadcast(); if (broadcastAddress != QHostAddress::Null && entry.ip() != QHostAddress::LocalHost) { broadcastAddresses << broadcastAddress; diff --git a/examples/network/network-chat/peermanager.h b/examples/network/network-chat/peermanager.h index b79028235b..6105c83115 100644 --- a/examples/network/network-chat/peermanager.h +++ b/examples/network/network-chat/peermanager.h @@ -70,7 +70,7 @@ public: void setServerPort(int port); QString userName() const; void startBroadcasting(); - bool isLocalHostAddress(const QHostAddress &address); + bool isLocalHostAddress(const QHostAddress &address) const; signals: void newConnection(Connection *connection); |