diff options
author | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2019-07-13 20:39:05 +0200 |
---|---|---|
committer | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2019-08-17 09:51:32 +0200 |
commit | 13426aff248c25b44ac377f37dc3e3a54ea0ea86 (patch) | |
tree | 18dfc93c88f5a06460c9adddb681901711dacd30 /examples/widgets/animation/sub-attaq/graphicsscene.h | |
parent | cb3e1e551f340ce1e6280123d8b5411b3c1c96d8 (diff) |
Cleanup QtWidgets animation examples
Cleanup the QtWidgets animation examples:
- use nullptr
- use normalized includes, remove unused includes
- fix style
- fix crash of sub-attaq when the game ended (error during range-based
for loop porting)
- don't use keyword 'final' for a variable name
Change-Id: Id23be8ff8b1b310da005d13c052fe547f6a0d63a
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'examples/widgets/animation/sub-attaq/graphicsscene.h')
-rw-r--r-- | examples/widgets/animation/sub-attaq/graphicsscene.h | 21 |
1 files changed, 10 insertions, 11 deletions
diff --git a/examples/widgets/animation/sub-attaq/graphicsscene.h b/examples/widgets/animation/sub-attaq/graphicsscene.h index 86c3414bbb..dd3719bc10 100644 --- a/examples/widgets/animation/sub-attaq/graphicsscene.h +++ b/examples/widgets/animation/sub-attaq/graphicsscene.h @@ -48,13 +48,12 @@ ** ****************************************************************************/ -#ifndef __GRAPHICSSCENE__H__ -#define __GRAPHICSSCENE__H__ +#ifndef GRAPHICSSCENE_H +#define GRAPHICSSCENE_H //Qt -#include <QtWidgets/QGraphicsScene> -#include <QtCore/QSet> -#include <QtCore/QState> +#include <QGraphicsScene> +#include <QSet> class Boat; @@ -78,18 +77,18 @@ public: }; struct SubmarineDescription { - int type; - int points; + int type = 0; + int points = 0; QString name; }; struct LevelDescription { - int id; + int id = 0; QString name; - QList<QPair<int,int> > submarines; + QVector<QPair<int, int>> submarines; }; - GraphicsScene(int x, int y, int width, int height, Mode mode = Big); + GraphicsScene(int x, int y, int width, int height, Mode mode, QObject *parent = nullptr); qreal sealLevel() const; void setupScene(QAction *newAction, QAction *quitAction); void addItem(Bomb *bomb); @@ -127,5 +126,5 @@ private: friend class UpdateScoreTransition; }; -#endif //__GRAPHICSSCENE__H__ +#endif // GRAPHICSSCENE_H |