diff options
author | Fabian Kosmale <fabian.kosmale@qt.io> | 2020-11-24 20:49:32 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2020-12-03 21:58:06 +0000 |
commit | 0b4adb5b63221d423e4bdd6d07b3460d3d5cc6fe (patch) | |
tree | e91685cc07a51ddb5972cf253faf524e1f88511e /examples/widgets/widgets/styles/norwegianwoodstyle.cpp | |
parent | e6e23d061cb8ac81007119603f8e7c64fc572e04 (diff) |
Avoid signed overflow in moc
moc's preprocessor needs to implement certain math operation to
correctly handle #if conditions. Unfortunately, its implementation is
not overflow safe. However, those are rare enough in practice that we
in general do not need to care about them.
This patch adds a workaround for one case where UBSAN run into an
overflow related issue.
A complete fix would require to make moc spec compliant (do math with
std::max_(u)int_t operands; always wrap on overflow) in all operations.
Fixes: QTBUG-88825
Change-Id: Ic4d2cb097db2fa2f9d4681bbaab3068eaa2745aa
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
(cherry picked from commit df8fbcf382b086e96082a8eb3622c60273e94c4d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'examples/widgets/widgets/styles/norwegianwoodstyle.cpp')
0 files changed, 0 insertions, 0 deletions