Polish the XML bookmarks examples

- Use Qt 5 connect syntax.
- Streamline code, remove unused members.
- Add a context menu for copying and opening the URLs.
- Add const to XML code.
- In the XML code, show the use of QStringLiteral in static inline
  functions to create strings versus QLatin1String in comparison
  overloads to avoid allocating strings from const char * literals.

Change-Id: Ib5e62ca188e271ffe01996dff3c9ea8e0b60739a
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>

1 files changed, 9 insertions, 9 deletions

diff --git a/examples/xml/saxbookmarks/xbelgenerator.cpp b/examples/xml/saxbookmarks/xbelgenerator.cpp
index 30ce1428e6..ee6f113f9c 100644
--- a/examples/xml/saxbookmarks/xbelgenerator.cpp
+++ b/examples/xml/saxbookmarks/xbelgenerator.cpp
@@ -52,7 +52,7 @@
 
 #include "xbelgenerator.h"
 
-XbelGenerator::XbelGenerator(QTreeWidget *treeWidget)
+XbelGenerator::XbelGenerator(const QTreeWidget *treeWidget)
     : treeWidget(treeWidget)
 {
 }
@@ -81,25 +81,25 @@ QString XbelGenerator::indent(int depth)
 QString XbelGenerator::escapedText(const QString &str)
 {
     QString result = str;
-    result.replace("&", "&");
-    result.replace("<", "&lt;");
-    result.replace(">", "&gt;");
+    result.replace('&', "&amp;");
+    result.replace('<', "&lt;");
+    result.replace('>', "&gt;");
     return result;
 }
 
 QString XbelGenerator::escapedAttribute(const QString &str)
 {
     QString result = escapedText(str);
-    result.replace("\"", "&quot;");
+    result.replace(QLatin1Char('"'), "&quot;");
     result.prepend(QLatin1Char('"'));
     result.append(QLatin1Char('"'));
     return result;
 }
 
-void XbelGenerator::generateItem(QTreeWidgetItem *item, int depth)
+void XbelGenerator::generateItem(const QTreeWidgetItem *item, int depth)
 {
     QString tagName = item->data(0, Qt::UserRole).toString();
-    if (tagName == "folder") {
+    if (tagName == QLatin1String("folder")) {
         bool folded = !treeWidget->isItemExpanded(item);
         out << indent(depth) << "<folder folded=\"" << (folded ? "yes" : "no")
                              << "\">\n"
@@ -110,7 +110,7 @@ void XbelGenerator::generateItem(QTreeWidgetItem *item, int depth)
             generateItem(item->child(i), depth + 1);
 
         out << indent(depth) << "</folder>\n";
-    } else if (tagName == "bookmark") {
+    } else if (tagName == QLatin1String("bookmark")) {
         out << indent(depth) << "<bookmark";
         if (!item->text(1).isEmpty())
             out << " href=" << escapedAttribute(item->text(1));
@@ -118,7 +118,7 @@ void XbelGenerator::generateItem(QTreeWidgetItem *item, int depth)
             << indent(depth + 1) << "<title>" << escapedText(item->text(0))
                                  << "</title>\n"
             << indent(depth) << "</bookmark>\n";
-    } else if (tagName == "separator") {
+    } else if (tagName == QLatin1String("separator")) {
         out << indent(depth) << "<separator/>\n";
     }
 }