diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2017-05-22 10:23:16 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2017-05-22 08:50:05 +0000 |
commit | d3f1076d0a3b8b0f44250399ea325020bbe9a0fd (patch) | |
tree | 362585a9e1428ddb39eb839f2c01832551fc1c7d /examples | |
parent | 6ec3a972971a6a83b74f5ccbb24c7bb088a863d3 (diff) |
QVulkanWindow: use QVector, not QSet, for small int set
Apart from being more efficient to construct and test, for the
expected very small number of entries, the example code itself shows
that a sorted vector is much more useful than an unordered set.
Change-Id: Ic5e38df0176ac4be08eac6a89c2e1cabab2a9020
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Diffstat (limited to 'examples')
-rw-r--r-- | examples/vulkan/hellovulkancubes/renderer.cpp | 2 | ||||
-rw-r--r-- | examples/vulkan/hellovulkanwidget/hellovulkanwidget.cpp | 3 | ||||
-rw-r--r-- | examples/vulkan/shared/trianglerenderer.cpp | 2 |
3 files changed, 3 insertions, 4 deletions
diff --git a/examples/vulkan/hellovulkancubes/renderer.cpp b/examples/vulkan/hellovulkancubes/renderer.cpp index 96ae6020a7..3b837d85d4 100644 --- a/examples/vulkan/hellovulkancubes/renderer.cpp +++ b/examples/vulkan/hellovulkancubes/renderer.cpp @@ -97,7 +97,7 @@ Renderer::Renderer(VulkanWindow *w, int initialCount) void Renderer::preInitResources() { - QSet<int> sampleCounts = m_window->supportedSampleCounts(); + const QVector<int> sampleCounts = m_window->supportedSampleCounts(); if (DBG) qDebug() << "Supported sample counts:" << sampleCounts; if (sampleCounts.contains(4)) { diff --git a/examples/vulkan/hellovulkanwidget/hellovulkanwidget.cpp b/examples/vulkan/hellovulkanwidget/hellovulkanwidget.cpp index 78de338f1f..81daa9bb96 100644 --- a/examples/vulkan/hellovulkanwidget/hellovulkanwidget.cpp +++ b/examples/vulkan/hellovulkanwidget/hellovulkanwidget.cpp @@ -170,8 +170,7 @@ void VulkanRenderer::initResources() m_window->colorFormat(), m_window->depthStencilFormat()); info += QStringLiteral("Supported sample counts:"); - QList<int> sampleCounts = m_window->supportedSampleCounts().toList(); - std::sort(sampleCounts.begin(), sampleCounts.end()); + const QVector<int> sampleCounts = m_window->supportedSampleCounts(); for (int count : sampleCounts) info += QLatin1Char(' ') + QString::number(count); info += QLatin1Char('\n'); diff --git a/examples/vulkan/shared/trianglerenderer.cpp b/examples/vulkan/shared/trianglerenderer.cpp index a0800080a0..7327c5a706 100644 --- a/examples/vulkan/shared/trianglerenderer.cpp +++ b/examples/vulkan/shared/trianglerenderer.cpp @@ -73,7 +73,7 @@ TriangleRenderer::TriangleRenderer(QVulkanWindow *w, bool msaa) : m_window(w) { if (msaa) { - QSet<int> counts = w->supportedSampleCounts(); + const QVector<int> counts = w->supportedSampleCounts(); qDebug() << "Supported sample counts:" << counts; for (int s = 16; s >= 4; s /= 2) { if (counts.contains(s)) { |