summaryrefslogtreecommitdiffstats
path: root/mkspecs
diff options
context:
space:
mode:
authorOswald Buddenhagen <oswald.buddenhagen@qt.io>2017-02-10 13:01:08 +0100
committerOswald Buddenhagen <oswald.buddenhagen@qt.io>2017-02-24 16:39:40 +0000
commit611b7c9ce77f1b02fc389583c24fbe7d49cce8a8 (patch)
tree646bd3e96d7c8f3b4442270bc13263a7ce5fc7b4 /mkspecs
parent07fffa60103fed42efed86f928fcec30f9d98815 (diff)
de-duplicate and simplify condition checking in qtConfProcessOneOutput()
amends 90eee08b3. Change-Id: If1fa2b14d758cc252d9a2ec3f9deedd1dd200c5e Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'mkspecs')
-rw-r--r--mkspecs/features/qt_configure.prf11
1 files changed, 2 insertions, 9 deletions
diff --git a/mkspecs/features/qt_configure.prf b/mkspecs/features/qt_configure.prf
index 6d78dc9484..aeaf666a5c 100644
--- a/mkspecs/features/qt_configure.prf
+++ b/mkspecs/features/qt_configure.prf
@@ -1739,10 +1739,6 @@ defineTest(qtConfProcessOneOutput) {
fpfx = $${currentConfig}.features.$${feature}
opfx = $${fpfx}.output.$${2}
- condition = $$eval($${opfx}.condition)
- !isEmpty(condition):!$$qtConfEvaluate($$condition): \
- return()
-
call = $$eval($${opfx}.type)
isEmpty(call) {
# output is just a string, not an object
@@ -1751,11 +1747,8 @@ defineTest(qtConfProcessOneOutput) {
!defined("qtConfOutput_$$call", test): \
error("Undefined type '$$call' in output '$$2' of feature '$$feature'.")
- condition = $$eval($${opfx}.condition)
- !isEmpty(condition) {
- !$$qtConfEvaluate($$condition): \
- return(false)
- }
+ !$$qtConfEvaluate($$eval($${opfx}.condition)): \
+ return()
$${opfx}.feature = $$feature
qtConfOutput_$${call}($$opfx, $$eval($${fpfx}.available))