Merge remote-tracking branch 'origin/5.9' into 5.10

Change-Id: I3cf73c53cf131d0babfb558c2507bed0e0fc5f08

4 files changed, 18 insertions, 32 deletions

diff --git a/mkspecs/features/ctest_testcase_common.prf b/mkspecs/features/ctest_testcase_common.prf
index f5eafc4e0d..1e3f9d2c1c 100644
--- a/mkspecs/features/ctest_testcase_common.prf
+++ b/mkspecs/features/ctest_testcase_common.prf
@@ -1,10 +1,5 @@
 
-win32 {
-    cmake_version_output = $$system(cmake --version 2>NUL, lines)
-} else {
-    cmake_version_output = $$system(cmake --version 2>/dev/null, lines)
-}
-
+cmake_version_output = $$system(cmake --version 2>$$QMAKE_SYSTEM_NULL_DEVICE, lines)
 # First line
 cmake_version_output = $$first(cmake_version_output)
 # Format is "cmake version X.Y.Z"
@@ -19,12 +14,7 @@ isEmpty(CMAKE_VERSION) {
     return()
 }
 
-win32 {
-    CTEST_VERSION = $$system(ctest --version 2>NUL)
-} else {
-    CTEST_VERSION = $$system(ctest --version 2>/dev/null)
-}
-
+CTEST_VERSION = $$system(ctest --version 2>$$QMAKE_SYSTEM_NULL_DEVICE)
 isEmpty(CTEST_VERSION) {
     message("ctest executable not found. Not running CMake unit tests")
     return()
diff --git a/mkspecs/features/qt_functions.prf b/mkspecs/features/qt_functions.prf
index c00fdb73f8..1903e509c8 100644
--- a/mkspecs/features/qt_functions.prf
+++ b/mkspecs/features/qt_functions.prf
@@ -291,10 +291,7 @@ defineReplace(pkgConfigExecutable) {
         }
     }
 
-    equals(QMAKE_HOST.os, Windows): \
-        PKG_CONFIG += 2> NUL
-    else: \
-        PKG_CONFIG += 2> /dev/null
+    PKG_CONFIG += 2> $$QMAKE_SYSTEM_NULL_DEVICE
 
     return($$PKG_CONFIG)
 }
diff --git a/mkspecs/features/spec_post.prf b/mkspecs/features/spec_post.prf
index f87bf3c037..432bb51516 100644
--- a/mkspecs/features/spec_post.prf
+++ b/mkspecs/features/spec_post.prf
@@ -82,6 +82,7 @@ equals(MAKEFILE_GENERATOR, MSBUILD) \
     QMAKE_MKDIR             = mkdir          # legacy
     QMAKE_MKDIR_CMD         = if not exist %1 mkdir %1 & if not exist %1 exit 1
     QMAKE_STREAM_EDITOR     = $(QMAKE) -install sed
+    QMAKE_SHELL_NULL_DEVICE = NUL
     QMAKE_INSTALL_FILE      = copy /y
     QMAKE_INSTALL_PROGRAM   = copy /y
 } else {
@@ -101,6 +102,7 @@ equals(MAKEFILE_GENERATOR, MSBUILD) \
     QMAKE_MKDIR             = mkdir -p   # legacy
     QMAKE_MKDIR_CMD         = test -d %1 || mkdir -p %1
     QMAKE_STREAM_EDITOR     = sed
+    QMAKE_SHELL_NULL_DEVICE = /dev/null
 
     equals(QMAKE_HOST.os, Windows) {
         MINGW_IN_SHELL = 1   # legacy
@@ -118,9 +120,11 @@ equals(MAKEFILE_GENERATOR, MSBUILD) \
 }
 QMAKE_INSTALL_DIR = $$QMAKE_COPY_DIR
 equals(QMAKE_HOST.os, Windows) {
-    QMAKE_SYMBOLIC_LINK     = $(QMAKE) -install ln -f -s
-    QMAKE_LN_SHLIB          = $(QMAKE) -install ln -s
+    QMAKE_SYMBOLIC_LINK      = $(QMAKE) -install ln -f -s
+    QMAKE_LN_SHLIB           = $(QMAKE) -install ln -s
+    QMAKE_SYSTEM_NULL_DEVICE = NUL
 } else {
-    QMAKE_SYMBOLIC_LINK     = ln -f -s
-    QMAKE_LN_SHLIB          = ln -s
+    QMAKE_SYMBOLIC_LINK      = ln -f -s
+    QMAKE_LN_SHLIB           = ln -s
+    QMAKE_SYSTEM_NULL_DEVICE = /dev/null
 }
diff --git a/mkspecs/features/toolchain.prf b/mkspecs/features/toolchain.prf
index 7b6f48de72..ba41598be1 100644
--- a/mkspecs/features/toolchain.prf
+++ b/mkspecs/features/toolchain.prf
@@ -32,15 +32,11 @@ isEmpty($${target_prefix}.INCDIRS) {
     # Get default include and library paths from compiler
     #
     gcc {
-        !equals(QMAKE_HOST.os, Windows) {
-            cmd_prefix = "LC_ALL=C"
-            cmd_suffix = "</dev/null >/dev/null"
-            null_file = /dev/null
-        } else {
+        cmd_suffix = "<$$QMAKE_SYSTEM_NULL_DEVICE >$$QMAKE_SYSTEM_NULL_DEVICE"
+        equals(QMAKE_HOST.os, Windows): \
             cmd_prefix = "set LC_ALL=C&"
-            cmd_suffix = "<NUL >NUL"
-            null_file = NUL
-        }
+        else: \
+            cmd_prefix = "LC_ALL=C"
 
         cxx_flags = $$QMAKE_CXXFLAGS
 
@@ -59,7 +55,7 @@ isEmpty($${target_prefix}.INCDIRS) {
 
         rim_qcc: \
             # Need the cc1plus and ld command lines to pick up the paths
-            cxx_flags += $$QMAKE_LFLAGS_SHLIB -o $$null_file -v
+            cxx_flags += $$QMAKE_LFLAGS_SHLIB -o $$QMAKE_SYSTEM_NULL_DEVICE -v
         else: darwin:clang: \
             # Need to link to pick up library paths
             cxx_flags += $$QMAKE_LFLAGS_SHLIB -o /dev/null -v -Wl,-v
@@ -175,9 +171,8 @@ defineReplace(qtVariablesFromMSVC) {
 }
 
 defineReplace(qtVariablesFromGCC) {
-    null_device = /dev/null
-    equals(QMAKE_HOST.os, Windows): null_device = NUL
-    ret = $$system("$$1 -E $$system_quote($$PWD/data/macros.cpp) <$$null_device 2>$$null_device", lines, ec)
+    ret = $$system("$$1 -E $$system_quote($$PWD/data/macros.cpp) \
+        <$$QMAKE_SYSTEM_NULL_DEVICE 2>$$QMAKE_SYSTEM_NULL_DEVICE", lines, ec)
     !equals(ec, 0): qtCompilerErrror($$1)
     return($$ret)
 }