path: root/qmake/generators/metamakefile.cpp
diff options
authorOswald Buddenhagen <>2012-02-21 12:56:47 +0100
committerQt by Nokia <>2012-03-02 21:33:08 +0100
commitdce3821b8a6dfbb041d7ecec8b97c960b0e08c51 (patch)
tree6284c89a29c19bd188cf89fe2c0adbebf7e98074 /qmake/generators/metamakefile.cpp
parentcd6e90c70ac13065257422088ffa01537ed9c685 (diff)
make evaluation of spec+cache independent of build pass context
don't inject the build pass specific variables into the project even before evaluating the .spec file and the .qmake.cache. they are not supposed to base configuration on that - feature files should do that later. the immediate advantage of this is that base_vars is never manipulated upfront any more, which allows for cleaner setup paths. also, we can do more caching of the spec+cache contents. Change-Id: I19d7f8bec1fb7c3b54121e26794340b287055ebf Reviewed-by: Joerg Bornemann <>
Diffstat (limited to 'qmake/generators/metamakefile.cpp')
1 files changed, 2 insertions, 2 deletions
diff --git a/qmake/generators/metamakefile.cpp b/qmake/generators/metamakefile.cpp
index 55ab0a5af5..39dd4ab797 100644
--- a/qmake/generators/metamakefile.cpp
+++ b/qmake/generators/metamakefile.cpp
@@ -243,13 +243,13 @@ MakefileGenerator
basecfgs = project->values(build + ".CONFIG");
basecfgs += build;
basecfgs += "build_pass";
- basevars["CONFIG"] = basecfgs;
basevars["BUILD_PASS"] = QStringList(build);
QStringList buildname = project->values(build + ".name");
basevars["BUILD_NAME"] = (buildname.isEmpty() ? QStringList(build) : buildname);
//create project
- QMakeProject *build_proj = new QMakeProject(project->properties(), basevars);
+ QMakeProject *build_proj = new QMakeProject(project->properties());
+ build_proj->setExtraVars(basevars);