diff options
author | Oswald Buddenhagen <oswald.buddenhagen@qt.io> | 2017-08-10 20:55:39 +0200 |
---|---|---|
committer | Tony Sarajärvi <tony.sarajarvi@qt.io> | 2017-08-26 12:11:53 +0000 |
commit | 9f98935d33cc15c938be2b9295ba2fbe4edb0ee0 (patch) | |
tree | f58c7f11169186eee1de2eadd978c8e90756cc87 /qmake/library | |
parent | ce5e6876d4a191087969134e489db99cf167ca69 (diff) |
qmake: prune obsolete QString::detach() call
no m_tmp is involved any more in this code path; it uses QStringRef.
amends 11d957d04381.
Change-Id: Ib272d61edfb150a549c5e6a9a60d53502702e802
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'qmake/library')
-rw-r--r-- | qmake/library/qmakeevaluator.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/qmake/library/qmakeevaluator.cpp b/qmake/library/qmakeevaluator.cpp index 7d9d6a5d8e..3fc8968cbd 100644 --- a/qmake/library/qmakeevaluator.cpp +++ b/qmake/library/qmakeevaluator.cpp @@ -1628,9 +1628,7 @@ bool QMakeEvaluator::isActiveConfig(const QStringRef &config, bool regex) return m_hostBuild; if (regex && (config.contains(QLatin1Char('*')) || config.contains(QLatin1Char('?')))) { - QString cfg = config.toString(); - cfg.detach(); // Keep m_tmp out of QRegExp's cache - QRegExp re(cfg, Qt::CaseSensitive, QRegExp::Wildcard); + QRegExp re(config.toString(), Qt::CaseSensitive, QRegExp::Wildcard); // mkspecs if (re.exactMatch(m_qmakespecName)) |