summaryrefslogtreecommitdiffstats
path: root/qmake
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@qt.io>2019-06-18 11:23:03 +0200
committerChristian Kandeler <christian.kandeler@qt.io>2019-06-18 11:23:03 +0200
commitfeb06decfe5355a14c982f7ddb427a262ad2b393 (patch)
tree18f2ebba0d818b692b8f677e07a0c0297bdb4192 /qmake
parent1e21867baf58d3f43a08c8f72406dd9dff279e4d (diff)
qmake: Let evaluateFunction() return error for infinite recursion
Otherwise, it can happen that parsing goes on forever in cumulative mode. Task-number: QTCREATORBUG-17656 Change-Id: If69f2265ac7eee0d230bd77a9aa9500e97ebeff6 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'qmake')
-rw-r--r--qmake/library/qmakeevaluator.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/qmake/library/qmakeevaluator.cpp b/qmake/library/qmakeevaluator.cpp
index 2db4f22f88..ba617932ce 100644
--- a/qmake/library/qmakeevaluator.cpp
+++ b/qmake/library/qmakeevaluator.cpp
@@ -1724,7 +1724,7 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateFunction(
if (m_valuemapStack.size() >= 100) {
evalError(fL1S("Ran into infinite recursion (depth > 100)."));
- vr = ReturnFalse;
+ vr = ReturnError;
} else {
m_valuemapStack.push(ProValueMap());
m_locationStack.push(m_current);