diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@qt.io> | 2016-12-16 13:34:02 +0100 |
|---|---|---|
| committer | Oswald Buddenhagen <oswald.buddenhagen@qt.io> | 2016-12-20 10:16:40 +0000 |
| commit | 33c33f6475910bad607abac67eef6c581d6188dd (patch) | |
| tree | c314f617b2ea810a4cd7b26a8307268395c12353 /qmake | |
| parent | d88ff29c57b5407339da00389c522e5f1d4e3398 (diff) | |
micro-optimize FOO-=$$BAR for empty FOO
there is no point in iterating BAR if FOO is (or became) empty.
Change-Id: I86c89bf0ad726a5ab7ead990a27ef7cc32caebbf
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'qmake')
| -rw-r--r-- | qmake/library/proitems.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/qmake/library/proitems.cpp b/qmake/library/proitems.cpp index 66db190bc1..f41ace6231 100644 --- a/qmake/library/proitems.cpp +++ b/qmake/library/proitems.cpp @@ -396,9 +396,12 @@ void ProStringList::removeAll(const char *str) void ProStringList::removeEach(const ProStringList &value) { - for (const ProString &str : value) + for (const ProString &str : value) { + if (isEmpty()) + break; if (!str.isEmpty()) removeAll(str); + } } void ProStringList::removeEmpty() |