diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2018-12-04 14:02:26 -0800 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@intel.com> | 2018-12-12 16:30:20 +0000 |
| commit | 2c6ec2c653af7f04bb98c6403b2e406cd493a8ab (patch) | |
| tree | bd1be5ca38d58c0c81ab0accc71b73cec170055f /src/corelib/codecs | |
| parent | d1cafa3ebac00f60cab3ca2beed6ebf2e6579a94 (diff) | |
Fix tautological compare in error checking
size is size_t, so it's never less than zero.
Fixes: QTBUG-72286
Change-Id: Idd0c85a4e7b64f9c9c7dfffd156d404d0de5ed8d
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/corelib/codecs')
| -rw-r--r-- | src/corelib/codecs/qwindowscodec.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/codecs/qwindowscodec.cpp b/src/corelib/codecs/qwindowscodec.cpp index 813d3c8153..6b703f7517 100644 --- a/src/corelib/codecs/qwindowscodec.cpp +++ b/src/corelib/codecs/qwindowscodec.cpp @@ -179,7 +179,7 @@ QString QWindowsLocalCodec::convertToUnicodeCharByChar(const char *chars, int le #else QString s; size_t size = mbstowcs(NULL, mb, length); - if (size < 0) { + if (size == size_t(-1)) { Q_ASSERT("Error in CE TextCodec"); return QString(); } |