diff options
| author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-01-23 13:05:12 +0400 |
|---|---|---|
| committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-02-13 16:29:16 +0000 |
| commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
| tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/corelib/doc/snippets | |
| parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) | |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/doc/snippets')
| -rw-r--r-- | src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp | 2 | ||||
| -rw-r--r-- | src/corelib/doc/snippets/qsignalmapper/buttonwidget.h | 2 | ||||
| -rw-r--r-- | src/corelib/doc/snippets/sharedemployee/employee.h | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp index 230be1f524..067853a5f6 100644 --- a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp +++ b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.cpp @@ -43,7 +43,7 @@ #include "buttonwidget.h" //! [0] -ButtonWidget::ButtonWidget(QStringList texts, QWidget *parent) +ButtonWidget::ButtonWidget(const QStringList &texts, QWidget *parent) : QWidget(parent) { signalMapper = new QSignalMapper(this); diff --git a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h index a6939603e8..b1803cf203 100644 --- a/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h +++ b/src/corelib/doc/snippets/qsignalmapper/buttonwidget.h @@ -53,7 +53,7 @@ class ButtonWidget : public QWidget Q_OBJECT public: - ButtonWidget(QStringList texts, QWidget *parent = 0); + ButtonWidget(const QStringList &texts, QWidget *parent = 0); signals: void clicked(const QString &text); diff --git a/src/corelib/doc/snippets/sharedemployee/employee.h b/src/corelib/doc/snippets/sharedemployee/employee.h index 9b673dceeb..83f630d299 100644 --- a/src/corelib/doc/snippets/sharedemployee/employee.h +++ b/src/corelib/doc/snippets/sharedemployee/employee.h @@ -63,7 +63,7 @@ class Employee //! [1] Employee() { d = new EmployeeData; } //! [1] //! [2] - Employee(int id, QString name) { + Employee(int id, const QString &name) { d = new EmployeeData; setId(id); setName(name); @@ -77,7 +77,7 @@ class Employee //! [3] void setId(int id) { d->id = id; } //! [3] //! [4] - void setName(QString name) { d->name = name; } + void setName(const QString &name) { d->name = name; } //! [4] //! [5] |