summaryrefslogtreecommitdiffstats
path: root/src/corelib/global
diff options
context:
space:
mode:
authorBoris Nagaev <bnagaev@gmail.com>2015-10-18 23:11:28 +0300
committerBoris Nagaev <bnagaev@gmail.com>2015-10-22 19:13:08 +0000
commit45fe3f1cde1e516d1ddccddb5e33ea4316497c36 (patch)
tree41d4c857f30937b0a550bc7ff9c5f69412efd094 /src/corelib/global
parent456f721917d07b3dd4259c324ff216f90bd32139 (diff)
configure: fix log corruption with option -v
This bug occurs if ./configure is called with -v on systems on which fd proc entries point to the files/devices they are open on instead of being magic nodes which would basically dup() the actual fds (e.g., Linux). In this case, the command "tee $tty" appends to /dev/stderr, which may be already opened by the parent process. This breaks the log file. Normally, the log file starts with This is the Qt Open Source Edition. ... but with `-v` flag it would start with output of awkprog and maybe some zero bytes. Zero bytes are observed on Debian Wheezy. DEFAULT_INCDIRS=... ... ^@^@^@^@^@^@^@^@^@^@^@^@... Done running configuration tests. ... To fix this problem, the output of `...` is saved to a variable, and then eval'd and echo'd (if -v). This solution was found by Tony Theodore. https://github.com/mxe/mxe/issues/938#issuecomment-149770348 Change-Id: Id0c28598890e813774cc92f38ee46a0697b34e77 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/global')
0 files changed, 0 insertions, 0 deletions