Fix resolution of relative symlinks from relative path on unix

Consider the following:
/root/target - a file
/root/path/link -> ../target
/root/path/other/exe - executable

Running from /root/path/other.

exe is:

#include <QDebug>
#include <QFileInfo>

int main()
{
    qDebug() << QFileInfo("../link").symLinkTarget()
    return 0;
}

The link references /root/target, but the current output is
/root/path/target.

The link doesn't depend on the PWD. It depends on its own directory.

Change-Id: I61e95018154a75e0e0d795ee801068e18870a5df
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 5 insertions, 7 deletions

diff --git a/src/corelib/io/qfilesystemengine_unix.cpp b/src/corelib/io/qfilesystemengine_unix.cpp
index ac0c43d055..7600c9a613 100644
--- a/src/corelib/io/qfilesystemengine_unix.cpp
+++ b/src/corelib/io/qfilesystemengine_unix.cpp
@@ -187,13 +187,11 @@ QFileSystemEntry QFileSystemEngine::getLinkTarget(const QFileSystemEntry &link,
 #endif
 
         if (!ret.startsWith(QLatin1Char('/'))) {
-            const QString linkFilePath = link.filePath();
-            if (linkFilePath.startsWith(QLatin1Char('/'))) {
-                ret.prepend(linkFilePath.leftRef(linkFilePath.lastIndexOf(QLatin1Char('/')))
-                            + QLatin1Char('/'));
-            } else {
-                ret.prepend(QDir::currentPath() + QLatin1Char('/'));
-            }
+            const QString linkPath = link.path();
+            if (linkPath.startsWith(QLatin1Char('/')))
+                ret.prepend(linkPath + QLatin1Char('/'));
+            else
+                ret.prepend(QDir::currentPath() + QLatin1Char('/') + linkPath + QLatin1Char('/'));
         }
         ret = QDir::cleanPath(ret);
         if (ret.size() > 1 && ret.endsWith(QLatin1Char('/')))