diff options
author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-01-23 13:05:12 +0400 |
---|---|---|
committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-02-13 16:29:16 +0000 |
commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/corelib/io/qfilesystemwatcher_fsevents.mm | |
parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/io/qfilesystemwatcher_fsevents.mm')
-rw-r--r-- | src/corelib/io/qfilesystemwatcher_fsevents.mm | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/corelib/io/qfilesystemwatcher_fsevents.mm b/src/corelib/io/qfilesystemwatcher_fsevents.mm index 1dc45a7e41..1076b8f5b4 100644 --- a/src/corelib/io/qfilesystemwatcher_fsevents.mm +++ b/src/corelib/io/qfilesystemwatcher_fsevents.mm @@ -283,13 +283,13 @@ void QFseventsFileSystemWatcherEngine::processEvent(ConstFSEventStreamRef stream #endif } -void QFseventsFileSystemWatcherEngine::doEmitFileChanged(const QString path, bool removed) +void QFseventsFileSystemWatcherEngine::doEmitFileChanged(const QString &path, bool removed) { DEBUG() << "emitting fileChanged for" << path << "with removed =" << removed; emit fileChanged(path, removed); } -void QFseventsFileSystemWatcherEngine::doEmitDirectoryChanged(const QString path, bool removed) +void QFseventsFileSystemWatcherEngine::doEmitDirectoryChanged(const QString &path, bool removed) { DEBUG() << "emitting directoryChanged for" << path << "with removed =" << removed; emit directoryChanged(path, removed); @@ -316,10 +316,10 @@ QFseventsFileSystemWatcherEngine::QFseventsFileSystemWatcherEngine(QObject *pare // We cannot use signal-to-signal queued connections, because the // QSignalSpy cannot spot signals fired from other/alien threads. - connect(this, SIGNAL(emitDirectoryChanged(const QString, bool)), - this, SLOT(doEmitDirectoryChanged(const QString, bool)), Qt::QueuedConnection); - connect(this, SIGNAL(emitFileChanged(const QString, bool)), - this, SLOT(doEmitFileChanged(const QString, bool)), Qt::QueuedConnection); + connect(this, SIGNAL(emitDirectoryChanged(QString,bool)), + this, SLOT(doEmitDirectoryChanged(QString,bool)), Qt::QueuedConnection); + connect(this, SIGNAL(emitFileChanged(QString,bool)), + this, SLOT(doEmitFileChanged(QString,bool)), Qt::QueuedConnection); connect(this, SIGNAL(scheduleStreamRestart()), this, SLOT(restartStream()), Qt::QueuedConnection); |