summaryrefslogtreecommitdiffstats
path: root/src/corelib/io/qprocess.cpp
diff options
context:
space:
mode:
authorJoerg Bornemann <joerg.bornemann@qt.io>2020-03-06 09:44:05 +0100
committerJoerg Bornemann <joerg.bornemann@qt.io>2020-03-06 10:00:01 +0100
commit2de3bfced35ae060acffc06e66e18279de6f5099 (patch)
treee065fb927b82fc3a6f909836fef90f22adcd9399 /src/corelib/io/qprocess.cpp
parent249a2e3271c3cc36edb88c993d277d93de2cf1c0 (diff)
Fix UB in QProcess deprecation warning fixes
The commits e1e08629 and 66e905b1 introduced undefined behavior. Fix this by assigning the result of takeFirst to a temporary. Change-Id: I9e29412cf632d4836b95d47e12d8c07ab0645fbb Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/corelib/io/qprocess.cpp')
-rw-r--r--src/corelib/io/qprocess.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/corelib/io/qprocess.cpp b/src/corelib/io/qprocess.cpp
index 9400662b97..4500467ac2 100644
--- a/src/corelib/io/qprocess.cpp
+++ b/src/corelib/io/qprocess.cpp
@@ -2522,7 +2522,8 @@ int QProcess::execute(const QString &command)
QStringList args = splitCommand(command);
if (args.isEmpty())
return -2;
- return execute(args.takeFirst(), args);
+ QString program = args.takeFirst();
+ return execute(program, args);
}
/*!