Obsolete command-string parsing QProcess::start/execute overloads

The command string parsing covers only simple quoting
patterns, while users tend to expect something that is in line with
their shell.
The overloads that take a QStringList are the recommended APIs to use
anyway, so exposing the splitting  method as a static function for
which we document the exact behavior allows callers to post-process
the QStringList, before calling the preferred overloads.

[ChangeLog][QtCore][QProcess] Overloads of start/execute/startDatached
that parse a single command string into program and arguments have
been marked as deprecated. A static helper splitCommand has
been added to construct a QStringList from a command string.

Change-Id: Ie91fcfb5eae6a52e5065efc60d2d9e068d20869d
Fixes: QTBUG-80640
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

1 files changed, 18 insertions, 1 deletions

diff --git a/src/corelib/io/qprocess.h b/src/corelib/io/qprocess.h
index 585508adf1..504b4a8061 100644
--- a/src/corelib/io/qprocess.h
+++ b/src/corelib/io/qprocess.h
@@ -160,8 +160,14 @@ public:
 
     void start(const QString &program, const QStringList &arguments, OpenMode mode = ReadWrite);
 #if !defined(QT_NO_PROCESS_COMBINED_ARGUMENT_START)
+#if QT_DEPRECATED_SINCE(5, 15)
+    QT_DEPRECATED_X(
+        "Use QProcess::start(const QString &program, const QStringList &arguments,"
+        "OpenMode mode = ReadWrite) instead"
+    )
     void start(const QString &command, OpenMode mode = ReadWrite);
 #endif
+#endif
     void start(OpenMode mode = ReadWrite);
     bool startDetached(qint64 *pid = nullptr);
     bool open(OpenMode mode = ReadWrite) override;
@@ -250,8 +256,12 @@ public:
     bool atEnd() const override; // ### Qt6: remove trivial override
 
     static int execute(const QString &program, const QStringList &arguments);
+#if QT_DEPRECATED_SINCE(5, 15)
+    QT_DEPRECATED_X(
+        "Use QProcess::execute(const QString &program, const QStringList &arguments) instead"
+    )
     static int execute(const QString &command);
-
+#endif
     static bool startDetached(const QString &program, const QStringList &arguments,
                               const QString &workingDirectory
 #if defined(Q_QDOC)
@@ -261,12 +271,19 @@ public:
 #if !defined(Q_QDOC)
     static bool startDetached(const QString &program, const QStringList &arguments); // ### Qt6: merge overloads
 #endif
+#if QT_DEPRECATED_SINCE(5, 15)
+    QT_DEPRECATED_X(
+        "Use QProcess::startDetached(const QString &program, const QStringList &arguments) instead"
+    )
     static bool startDetached(const QString &command);
+#endif
 
     static QStringList systemEnvironment();
 
     static QString nullDevice();
 
+    static QStringList splitCommand(const QString &command);
+
 public Q_SLOTS:
     void terminate();
     void kill();