diff options
author | Sergio Ahumada <sergio.ahumada@nokia.com> | 2012-09-08 19:08:53 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-09-14 15:23:15 +0200 |
commit | 0a37bcf24547101595299572533e5e3a98e04e1d (patch) | |
tree | 015338f188df67ebdfe4a5ab7c2fd8fc84251be7 /src/corelib/io | |
parent | 26b6cce44bc4fb81b09420bdaf56fc6036d1eece (diff) |
Mark (non-public API's) ctor's as explicit
Make C++ class constructors that can be used with only one
required argument 'explicit' to minimize wrong use of the class.
Change-Id: I12ad5b6eb1794108c6b7464a2573e84068733b03
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/io')
-rw-r--r-- | src/corelib/io/qdir_p.h | 8 | ||||
-rw-r--r-- | src/corelib/io/qwindowspipewriter_p.h | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/corelib/io/qdir_p.h b/src/corelib/io/qdir_p.h index 88d681996d..10a82cd580 100644 --- a/src/corelib/io/qdir_p.h +++ b/src/corelib/io/qdir_p.h @@ -50,11 +50,11 @@ QT_BEGIN_NAMESPACE class QDirPrivate : public QSharedData { public: - QDirPrivate(const QString &path, const QStringList &nameFilters_ = QStringList(), - QDir::SortFlags sort_ = QDir::SortFlags(QDir::Name | QDir::IgnoreCase), - QDir::Filters filters_ = QDir::AllEntries); + explicit QDirPrivate(const QString &path, const QStringList &nameFilters_ = QStringList(), + QDir::SortFlags sort_ = QDir::SortFlags(QDir::Name | QDir::IgnoreCase), + QDir::Filters filters_ = QDir::AllEntries); - QDirPrivate(const QDirPrivate ©); + explicit QDirPrivate(const QDirPrivate ©); bool exists() const; diff --git a/src/corelib/io/qwindowspipewriter_p.h b/src/corelib/io/qwindowspipewriter_p.h index fd648deefc..affd17f3e2 100644 --- a/src/corelib/io/qwindowspipewriter_p.h +++ b/src/corelib/io/qwindowspipewriter_p.h @@ -123,7 +123,7 @@ Q_SIGNALS: void bytesWritten(qint64 bytes); public: - QWindowsPipeWriter(HANDLE writePipe, QObject * parent = 0); + explicit QWindowsPipeWriter(HANDLE writePipe, QObject * parent = 0); ~QWindowsPipeWriter(); bool waitForWrite(int msecs); |