diff options
| author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-04-21 21:58:58 +0300 |
|---|---|---|
| committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-04-25 07:46:02 +0000 |
| commit | 84330007e12122bf1b690a4e68b5ef8e973c7882 (patch) | |
| tree | 6d57fd55a65e3a1f6699824ccc46a4930bc73c40 /src/corelib/io | |
| parent | be6c14211e93da4b59c4c25aa8e85b860ccb8666 (diff) | |
QLockFile: move early out earlier to avoid allocations.
Saves reading two lines and allocating storage for them.
Change-Id: I71f6c7019f4c097897945eea52851e4623b75dc2
Reviewed-by: David Faure <david.faure@kdab.com>
Reviewed-by: Edward Welbourne <edward.welbourne@theqtcompany.com>
Diffstat (limited to 'src/corelib/io')
| -rw-r--r-- | src/corelib/io/qlockfile.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/corelib/io/qlockfile.cpp b/src/corelib/io/qlockfile.cpp index 7e39dc56fb..cb61a52c04 100644 --- a/src/corelib/io/qlockfile.cpp +++ b/src/corelib/io/qlockfile.cpp @@ -293,12 +293,12 @@ bool QLockFilePrivate::getLockInfo(qint64 *pid, QString *hostname, QString *appn QByteArray pidLine = reader.readLine(); pidLine.chop(1); + if (pidLine.isEmpty()) + return false; QByteArray appNameLine = reader.readLine(); appNameLine.chop(1); QByteArray hostNameLine = reader.readLine(); hostNameLine.chop(1); - if (pidLine.isEmpty()) - return false; qint64 thePid = pidLine.toLongLong(); if (pid) |