diff options
| author | David Faure <david.faure@kdab.com> | 2019-04-13 15:38:15 +0200 |
|---|---|---|
| committer | David Faure <david.faure@kdab.com> | 2019-04-23 16:17:15 +0000 |
| commit | 20e286107344f2cb188f5292d31dc62bf7708365 (patch) | |
| tree | eb6fb934e3819b7bbbffe011713a9de402315318 /src/corelib/itemmodels/qabstractitemmodel.cpp | |
| parent | 54ceb8a5f86465dcde334973dedf401b31210e63 (diff) | |
Optimize QAbstractTableModel::hasChildren
Valid indexes cannot have children, in a table model, so there's no
point in asking the model about it (by calling rowCount and
columnCount).
Change-Id: Ic2d7b52538a7b67acb2c35b26e69bba5956ef5af
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
Diffstat (limited to 'src/corelib/itemmodels/qabstractitemmodel.cpp')
| -rw-r--r-- | src/corelib/itemmodels/qabstractitemmodel.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/itemmodels/qabstractitemmodel.cpp b/src/corelib/itemmodels/qabstractitemmodel.cpp index 18f0f6f55f..25a80a640c 100644 --- a/src/corelib/itemmodels/qabstractitemmodel.cpp +++ b/src/corelib/itemmodels/qabstractitemmodel.cpp @@ -3618,7 +3618,7 @@ QModelIndex QAbstractTableModel::sibling(int row, int column, const QModelIndex bool QAbstractTableModel::hasChildren(const QModelIndex &parent) const { - if (parent.model() == this || !parent.isValid()) + if (!parent.isValid()) return rowCount(parent) > 0 && columnCount(parent) > 0; return false; } |