Deprecate the use of QWeakPointer to track QObjects.

The main problem with using QWeakPointer to track QObjects is that it
has API to convert to QSharedPointer, which is undefined behavior. There
is no need to overload the meaning of QWeakPointer with QObject
tracking.

QPointer is more suitable and should be used instead. Because QPointer
is implemented in terms of QWeakPointer, we need to add some overloads
which are not deprecated.

Change-Id: If0333e4800c9fd277629cc69185c9ca3e4e7e81d
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/corelib/kernel/qpointer.h b/src/corelib/kernel/qpointer.h
index 5544a59705..88d8225621 100644
--- a/src/corelib/kernel/qpointer.h
+++ b/src/corelib/kernel/qpointer.h
@@ -57,7 +57,7 @@ class QPointerBase
 
 protected:
     inline QPointerBase() : wp() { }
-    inline QPointerBase(QObject *p) : wp(p) { }
+    inline QPointerBase(QObject *p) : wp(p, true) { }
     // compiler-generated copy/move ctor/assignment operators are fine! (even though public)
     inline ~QPointerBase() { }
 
@@ -65,7 +65,7 @@ protected:
     { return wp.data(); }
 
     inline void assign(QObject *p)
-    { wp = p; }
+    { wp.assign(p); }
 
     inline bool isNull() const
     { return wp.isNull(); }