summaryrefslogtreecommitdiffstats
path: root/src/corelib/mimetypes
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2020-04-28 12:57:55 +0200
committerLars Knoll <lars.knoll@qt.io>2020-05-02 21:32:05 +0200
commit74306a02ce4e4d4c499d416885dd78d031bcb961 (patch)
treef696304a898d2b9228f2742df59208b28e4ceba0 /src/corelib/mimetypes
parent8d8940243541e67df8f8683e473e205416eedff6 (diff)
Don't use a QTextStream to read lines from a file
QFile::readLine() can do the same at a fraction of the cost of QTextStream. Change-Id: I8c542756bcbd893dfa76d03e76e3ce0810aa2871 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/mimetypes')
-rw-r--r--src/corelib/mimetypes/qmimeprovider.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/corelib/mimetypes/qmimeprovider.cpp b/src/corelib/mimetypes/qmimeprovider.cpp
index 04d6d6220b..83574a40f0 100644
--- a/src/corelib/mimetypes/qmimeprovider.cpp
+++ b/src/corelib/mimetypes/qmimeprovider.cpp
@@ -456,11 +456,12 @@ void QMimeBinaryProvider::loadMimeTypeList()
// So we have to parse the plain-text files called "types".
QFile file(m_directory + QStringLiteral("/types"));
if (file.open(QIODevice::ReadOnly)) {
- QTextStream stream(&file);
- stream.setCodec("ISO 8859-1");
- QString line;
- while (stream.readLineInto(&line))
- m_mimetypeNames.insert(line);
+ while (!file.atEnd()) {
+ QByteArray line = file.readLine();
+ if (line.endsWith('\n'))
+ line.chop(1);
+ m_mimetypeNames.insert(QString::fromLatin1(line));
+ }
}
}
}