diff options
author | Thiago Macieira <thiago.macieira@intel.com> | 2018-07-08 10:34:27 -0700 |
---|---|---|
committer | Thiago Macieira <thiago.macieira@intel.com> | 2018-07-14 04:20:32 +0000 |
commit | 503646a3317c1041fb5ded803a3935ef330ea036 (patch) | |
tree | 4e65e04b1ff213b76f9ba917ade49580a787a73d /src/corelib/serialization/qcborvalue_p.h | |
parent | 6fd98af332e405e63f040d0312bf8aba5ade4e29 (diff) |
QCborValue: Silence Coverity warning about null-pointer dereference
It's a false positive, since we've checked that the item HasByteData.
But it's cheap to rewrite so the warning is silenced.
>>> CID 190741: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a null pointer "this->byteData(idx)".
Change-Id: If48c5c2e920c433298f1fffd153f7534be42a30b
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src/corelib/serialization/qcborvalue_p.h')
-rw-r--r-- | src/corelib/serialization/qcborvalue_p.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/corelib/serialization/qcborvalue_p.h b/src/corelib/serialization/qcborvalue_p.h index f6c0cfae3d..02aa05bcdb 100644 --- a/src/corelib/serialization/qcborvalue_p.h +++ b/src/corelib/serialization/qcborvalue_p.h @@ -205,8 +205,8 @@ public: e.container->deref(); e.container = nullptr; e.flags = {}; - } else if (e.flags & QtCbor::Element::HasByteData) { - usedData -= byteData(idx)->len + sizeof(QtCbor::ByteData); + } else if (auto b = byteData(e)) { + usedData -= b->len + sizeof(QtCbor::ByteData); } replaceAt_internal(e, value, disp); } |