diff options
author | Alessandro Portale <alessandro.portale@qt.io> | 2018-07-25 23:25:10 +0200 |
---|---|---|
committer | Alessandro Portale <alessandro.portale@qt.io> | 2018-09-25 13:34:19 +0000 |
commit | d0c159c8e306709629e3af0b83b464c5cea15754 (patch) | |
tree | 45258dc9f251916707f64ff6dda515316bef4e6b /src/corelib/statemachine | |
parent | 35ec3b49e1b0e7c72643a4e5b835bff57762f8cb (diff) |
Fix a few overrides in Qt Core
This change removes redundant 'virtual' from function declarations.
Clang Tidy's modernize-use-override check reports:
warning: 'virtual' is redundant since the function is already
declared 'override'
CppCoreGuidelines say:
C.128: Virtual functions should specify exactly one of virtual,
override, or final
Change-Id: I9a4bdd6cc041d46ae64b25597ba4f7268ac4c2b7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Kevin Funk <kevin.funk@kdab.com>
Diffstat (limited to 'src/corelib/statemachine')
-rw-r--r-- | src/corelib/statemachine/qsignaltransition_p.h | 2 | ||||
-rw-r--r-- | src/corelib/statemachine/qstatemachine.cpp | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/corelib/statemachine/qsignaltransition_p.h b/src/corelib/statemachine/qsignaltransition_p.h index 0666e600a4..b3de334677 100644 --- a/src/corelib/statemachine/qsignaltransition_p.h +++ b/src/corelib/statemachine/qsignaltransition_p.h @@ -70,7 +70,7 @@ public: void unregister(); void maybeRegister(); - virtual void callOnTransition(QEvent *e) override; + void callOnTransition(QEvent *e) override; const QObject *sender; QByteArray signal; diff --git a/src/corelib/statemachine/qstatemachine.cpp b/src/corelib/statemachine/qstatemachine.cpp index 24734f99ac..6f0306f80c 100644 --- a/src/corelib/statemachine/qstatemachine.cpp +++ b/src/corelib/statemachine/qstatemachine.cpp @@ -1721,8 +1721,8 @@ QAbstractTransition *QStateMachinePrivate::createInitialTransition() const : QAbstractTransition() { setTargetStates(targets); } protected: - virtual bool eventTest(QEvent *) override { return true; } - virtual void onTransition(QEvent *) override {} + bool eventTest(QEvent *) override { return true; } + void onTransition(QEvent *) override {} }; QState *root = rootState(); |