diff options
author | Lars Knoll <lars.knoll@qt.io> | 2020-10-31 15:33:57 +0100 |
---|---|---|
committer | Lars Knoll <lars.knoll@qt.io> | 2020-11-04 11:22:11 +0100 |
commit | edd1e931d1f0a1c5f9b2c1869d34db577307605d (patch) | |
tree | 9e372aba0c139e9369e43efa62829cde5ff7740c /src/corelib/text/qbytearray.cpp | |
parent | 4d49459e4bc95debedd526eac117f21cab8efbb5 (diff) |
Fix performance issue with QList::insert() for complex T
When storing complex types in the list and inserting in the middle,
we ended up in some cases moving the items in the list onto itself,
to make space for 0 new items.
Obviously that's not a very good idea. It was not a huge deal for
POD or relocatable types as we'd use memmove in that case which would
return quickly. But for complex types, we actually did copy around
half of the items stored in the list onto themselves.
Change-Id: I54467dccf2e17ba4a604bded755242197dd96b06
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Diffstat (limited to 'src/corelib/text/qbytearray.cpp')
0 files changed, 0 insertions, 0 deletions