diff options
| author | Albert Astals Cid <albert.astals.cid@kdab.com> | 2020-05-07 16:13:32 +0200 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-05-21 18:02:03 +0200 |
| commit | 9b8ad6a17e9211aae245f0d08a2d2e69eaae17cd (patch) | |
| tree | c7c8090d2353d0d59bf3414b44dab3dd04d63cf1 /src/corelib/text | |
| parent | b8234e564a68082987f63ba644fe97e7c6b9a07f (diff) | |
QByteArrayLiteral: Remove const temporary that may prevent optimization
clang-tidy 10 was complaining about
http://clang.llvm.org/extra/clang-tidy/checks/performance-no-automatic-move.html
Change-Id: I63ba4111e01bb9d3ee87940253c4a79cc42c0bdf
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 4fa94440902d87b41f6cda7e5fd057dc8e79f08d)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/corelib/text')
| -rw-r--r-- | src/corelib/text/qbytearray.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/corelib/text/qbytearray.h b/src/corelib/text/qbytearray.h index e3bb9ea937..dac4f05a40 100644 --- a/src/corelib/text/qbytearray.h +++ b/src/corelib/text/qbytearray.h @@ -148,8 +148,7 @@ struct QByteArrayDataPtr Q_STATIC_BYTE_ARRAY_DATA_HEADER_INITIALIZER(Size), \ str }; \ QByteArrayDataPtr holder = { qbytearray_literal.data_ptr() }; \ - const QByteArray ba(holder); \ - return ba; \ + return QByteArray(holder); \ }()) \ /**/ |