QtCore: Use Q_REQUIRED_RESULT in many more places

gcc doesn't yet warn when a non-POD return datatype is unused,
but clang does, at least.

This detected two bugs in qtbase due to the bad QDate method naming,
and will help application developers to avoid this trap too.

Change-Id: I106c1a32d2c6fc8d02f57beb7b61940605c80d76
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>

1 files changed, 18 insertions, 18 deletions

diff --git a/src/corelib/tools/qrect.h b/src/corelib/tools/qrect.h
index 2bb74e8221..8ee08877e8 100644
--- a/src/corelib/tools/qrect.h
+++ b/src/corelib/tools/qrect.h
@@ -68,7 +68,7 @@ public:
     Q_DECL_CONSTEXPR inline int top() const;
     Q_DECL_CONSTEXPR inline int right() const;
     Q_DECL_CONSTEXPR inline int bottom() const;
-    QRect normalized() const;
+    QRect normalized() const Q_REQUIRED_RESULT;
 
     Q_DECL_CONSTEXPR inline int x() const;
     Q_DECL_CONSTEXPR inline int y() const;
@@ -102,8 +102,8 @@ public:
 
     inline void translate(int dx, int dy);
     inline void translate(const QPoint &p);
-    Q_DECL_CONSTEXPR inline QRect translated(int dx, int dy) const;
-    Q_DECL_CONSTEXPR inline QRect translated(const QPoint &p) const;
+    Q_DECL_CONSTEXPR inline QRect translated(int dx, int dy) const Q_REQUIRED_RESULT;
+    Q_DECL_CONSTEXPR inline QRect translated(const QPoint &p) const Q_REQUIRED_RESULT;
 
     inline void moveTo(int x, int t);
     inline void moveTo(const QPoint &p);
@@ -115,7 +115,7 @@ public:
     inline void getCoords(int *x1, int *y1, int *x2, int *y2) const;
 
     inline void adjust(int x1, int y1, int x2, int y2);
-    Q_DECL_CONSTEXPR inline QRect adjusted(int x1, int y1, int x2, int y2) const;
+    Q_DECL_CONSTEXPR inline QRect adjusted(int x1, int y1, int x2, int y2) const Q_REQUIRED_RESULT;
 
     Q_DECL_CONSTEXPR inline QSize size() const;
     Q_DECL_CONSTEXPR inline int width() const;
@@ -133,8 +133,8 @@ public:
     bool contains(const QPoint &p, bool proper=false) const;
     inline bool contains(int x, int y) const;
     inline bool contains(int x, int y, bool proper) const;
-    inline QRect united(const QRect &other) const;
-    inline QRect intersected(const QRect &other) const;
+    inline QRect united(const QRect &other) const Q_REQUIRED_RESULT;
+    inline QRect intersected(const QRect &other) const Q_REQUIRED_RESULT;
     bool intersects(const QRect &r) const;
 
     Q_DECL_CONSTEXPR inline QRect marginsAdded(const QMargins &margins) const;
@@ -143,8 +143,8 @@ public:
     inline QRect &operator-=(const QMargins &margins);
 
 #if QT_DEPRECATED_SINCE(5, 0)
-    QT_DEPRECATED QRect unite(const QRect &r) const { return united(r); }
-    QT_DEPRECATED QRect intersect(const QRect &r) const { return intersected(r); }
+    QT_DEPRECATED QRect unite(const QRect &r) const Q_REQUIRED_RESULT { return united(r); }
+    QT_DEPRECATED QRect intersect(const QRect &r) const Q_REQUIRED_RESULT { return intersected(r); }
 #endif
 
     friend Q_DECL_CONSTEXPR inline bool operator==(const QRect &, const QRect &);
@@ -510,7 +510,7 @@ public:
     Q_DECL_CONSTEXPR inline bool isNull() const;
     Q_DECL_CONSTEXPR inline bool isEmpty() const;
     Q_DECL_CONSTEXPR inline bool isValid() const;
-    QRectF normalized() const;
+    QRectF normalized() const Q_REQUIRED_RESULT;
 
     Q_DECL_CONSTEXPR inline qreal left() const { return xp; }
     Q_DECL_CONSTEXPR inline qreal top() const { return yp; }
@@ -550,8 +550,8 @@ public:
     inline void translate(qreal dx, qreal dy);
     inline void translate(const QPointF &p);
 
-    Q_DECL_CONSTEXPR inline QRectF translated(qreal dx, qreal dy) const;
-    Q_DECL_CONSTEXPR inline QRectF translated(const QPointF &p) const;
+    Q_DECL_CONSTEXPR inline QRectF translated(qreal dx, qreal dy) const Q_REQUIRED_RESULT;
+    Q_DECL_CONSTEXPR inline QRectF translated(const QPointF &p) const Q_REQUIRED_RESULT;
 
     inline void moveTo(qreal x, qreal y);
     inline void moveTo(const QPointF &p);
@@ -563,7 +563,7 @@ public:
     inline void getCoords(qreal *x1, qreal *y1, qreal *x2, qreal *y2) const;
 
     inline void adjust(qreal x1, qreal y1, qreal x2, qreal y2);
-    Q_DECL_CONSTEXPR inline QRectF adjusted(qreal x1, qreal y1, qreal x2, qreal y2) const;
+    Q_DECL_CONSTEXPR inline QRectF adjusted(qreal x1, qreal y1, qreal x2, qreal y2) const Q_REQUIRED_RESULT;
 
     Q_DECL_CONSTEXPR inline QSizeF size() const;
     Q_DECL_CONSTEXPR inline qreal width() const;
@@ -580,8 +580,8 @@ public:
     bool contains(const QRectF &r) const;
     bool contains(const QPointF &p) const;
     inline bool contains(qreal x, qreal y) const;
-    inline QRectF united(const QRectF &other) const;
-    inline QRectF intersected(const QRectF &other) const;
+    inline QRectF united(const QRectF &other) const Q_REQUIRED_RESULT;
+    inline QRectF intersected(const QRectF &other) const Q_REQUIRED_RESULT;
     bool intersects(const QRectF &r) const;
 
     Q_DECL_CONSTEXPR inline QRectF marginsAdded(const QMarginsF &margins) const;
@@ -590,15 +590,15 @@ public:
     inline QRectF &operator-=(const QMarginsF &margins);
 
 #if QT_DEPRECATED_SINCE(5, 0)
-    QT_DEPRECATED QRectF unite(const QRectF &r) const { return united(r); }
-    QT_DEPRECATED QRectF intersect(const QRectF &r) const { return intersected(r); }
+    QT_DEPRECATED QRectF unite(const QRectF &r) const Q_REQUIRED_RESULT { return united(r); }
+    QT_DEPRECATED QRectF intersect(const QRectF &r) const Q_REQUIRED_RESULT { return intersected(r); }
 #endif
 
     friend Q_DECL_CONSTEXPR inline bool operator==(const QRectF &, const QRectF &);
     friend Q_DECL_CONSTEXPR inline bool operator!=(const QRectF &, const QRectF &);
 
-    Q_DECL_CONSTEXPR inline QRect toRect() const;
-    QRect toAlignedRect() const;
+    Q_DECL_CONSTEXPR inline QRect toRect() const Q_REQUIRED_RESULT;
+    QRect toAlignedRect() const Q_REQUIRED_RESULT;
 
 private:
     qreal xp;