diff options
| author | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2021-09-18 11:29:23 +0200 |
|---|---|---|
| committer | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2021-09-19 18:04:06 +0200 |
| commit | c578d9943afd4478d9bf813067b002f2679df1d4 (patch) | |
| tree | 0958fe745c5b1e0c39021f98899630f7306ae674 /src/corelib/tools | |
| parent | 7eeda336b4ab45e6869f848d6378043337cd37a1 (diff) | |
Plaster [[nodiscard]] on some RAII classes
The idea is to prevent silly mistakes such as
QMutexLocker(mutex);
doSomething();
where the locker is constructed and destroyed immediately. Compilers
don't normally warn in these cases (as the constructor/destructor
pairs involved do have side effects), but we can mark the type as
[[nodiscard]] to encourage warnings.
There is another couple of classes for which this would make sense
(notably, the R/W lockers), but unfortunately those are exported
classes, and GCC has a bug where one can't mix two different attribute
syntaxes on the same entity [1], so I'm skipping those.
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102399
Change-Id: I75a2443dc71e6b80613b8edd52a04d3379355728
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/corelib/tools')
| -rw-r--r-- | src/corelib/tools/qscopedpointer.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/corelib/tools/qscopedpointer.h b/src/corelib/tools/qscopedpointer.h index 5c72e7415d..43e0718699 100644 --- a/src/corelib/tools/qscopedpointer.h +++ b/src/corelib/tools/qscopedpointer.h @@ -103,7 +103,7 @@ typedef QScopedPointerObjectDeleteLater<QObject> QScopedPointerDeleteLater; #endif template <typename T, typename Cleanup = QScopedPointerDeleter<T> > -class QScopedPointer +class [[nodiscard]] QScopedPointer { public: explicit QScopedPointer(T *p = nullptr) noexcept : d(p) @@ -223,7 +223,7 @@ private: }; template <typename T, typename Cleanup = QScopedPointerArrayDeleter<T> > -class QScopedArrayPointer : public QScopedPointer<T, Cleanup> +class [[nodiscard]] QScopedArrayPointer : public QScopedPointer<T, Cleanup> { template <typename Ptr> using if_same_type = typename std::enable_if<std::is_same<typename std::remove_cv<T>::type, Ptr>::value, bool>::type; |