path: root/src/corelib/xml
diff options
authorThiago Macieira <>2012-04-20 14:59:30 +0200
committerQt by Nokia <>2012-04-27 22:52:54 +0200
commitda2c170aa25bc6e8fd6cd0788fae14ee455ce359 (patch)
treef0e605c55b1d9f32c60a97c03eba909cfbfc012b /src/corelib/xml
parentd78d5ddf2ac5433b09dad2658f810e9de767dfea (diff)
Don't use the QRegExp methods that modify the object [QtCore]
QRegExp matching methods modify the object, which we don't want to. In particular, when we receive a QRegExp from the user or we store in a context that might require thread-safety, make sure we make a copy before using it. QRegularExpression has no such shortcoming. Task-number: QTBUG-25064 Change-Id: Icf22986cd5f6fd086518c78a7d56e6cadfe9f5f6 Reviewed-by: Giuseppe D'Angelo <> Reviewed-by: Lars Knoll <>
Diffstat (limited to 'src/corelib/xml')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/xml/qxmlutils.cpp b/src/corelib/xml/qxmlutils.cpp
index 89912b42fa..44a56de797 100644
--- a/src/corelib/xml/qxmlutils.cpp
+++ b/src/corelib/xml/qxmlutils.cpp
@@ -236,7 +236,7 @@ bool QXmlUtils::isEncName(const QString &encName)
* replace that regexp is probably a 70 lines so I prioritize this to when
* the dependency is considered alarming, or when the rest of the bugs
* are fixed. */
- const QRegExp encNameRegExp(QLatin1String("[A-Za-z][A-Za-z0-9._\\-]*"));
+ QRegExp encNameRegExp(QLatin1String("[A-Za-z][A-Za-z0-9._\\-]*"));
return encNameRegExp.exactMatch(encName);