diff options
author | Marc Mutz <marc.mutz@qt.io> | 2022-03-15 21:20:46 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-03-19 16:32:21 +0000 |
commit | f36a013be529b32a0f1b8e2fffb3153609f15ccd (patch) | |
tree | 6b5e01974c3bda3229436b4e052664527799c639 /src/gui/image/qicon.h | |
parent | 874687902df20f0fdd0b39d84ffd89e6668e1088 (diff) |
QtGui: compile-optimize inline swap functions
Instead of using the overly-generic qSwap() monster, use
- qt_ptr_swap() for swapping raw pointers
- member-swap for swapping smart pointers
- std::swap() for swapping scalars
In QtCore, this has proven to give a nice reduction in compile time
for Qt users, cf. b1b0c2970e480ef460a61f37fa430dc443390358.
Task-number: QTBUG-97601
Change-Id: I987ff95e8751a22a4f283655d8225dd16de21178
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit c839efb07a6aa3b487dac5f86f905f35ef2c3a08)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/gui/image/qicon.h')
-rw-r--r-- | src/gui/image/qicon.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/image/qicon.h b/src/gui/image/qicon.h index fab8c3fe21..d5e192893a 100644 --- a/src/gui/image/qicon.h +++ b/src/gui/image/qicon.h @@ -70,7 +70,7 @@ public: QIcon &operator=(const QIcon &other); QT_MOVE_ASSIGNMENT_OPERATOR_IMPL_VIA_MOVE_AND_SWAP(QIcon) inline void swap(QIcon &other) noexcept - { qSwap(d, other.d); } + { qt_ptr_swap(d, other.d); } bool operator==(const QIcon &) const = delete; bool operator!=(const QIcon &) const = delete; |