QtGui: replace some copies with swaps

This provides move speed even for non-C++11 compilers and avoids
having to call the copy assignment operator from within copy ctors.
(which will result in infinite recursion when using the copy-swap idiom).

Change-Id: I379bc8bf2c72d9f986c0f17f9eef56cd592e7a06
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/gui/image/qpixmap.cpp b/src/gui/image/qpixmap.cpp
index 183c13698a..c1a63f5101 100644
--- a/src/gui/image/qpixmap.cpp
+++ b/src/gui/image/qpixmap.cpp
@@ -226,7 +226,7 @@ QPixmap::QPixmap(const QPixmap &pixmap)
         return;
     }
     if (pixmap.paintingActive()) {                // make a deep copy
-        operator=(pixmap.copy());
+        pixmap.copy().swap(*this);
     } else {
         data = pixmap.data;
     }
@@ -384,7 +384,7 @@ QPixmap &QPixmap::operator=(const QPixmap &pixmap)
         return *this;
     }
     if (pixmap.paintingActive()) {                // make a deep copy
-        *this = pixmap.copy();
+        pixmap.copy().swap(*this);
     } else {
         data = pixmap.data;
     }