diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2014-08-22 21:03:34 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2014-08-23 13:18:23 +0200 |
commit | 6244665faa0c703efa29943832d8c90726f7e8b1 (patch) | |
tree | 8d90afcb5bb32bfde34ecea00da8b908e750a9fb /src/gui/image | |
parent | 5335a7153549fcb66f357c04b3b94e3ab112dc4e (diff) |
QIconLoader: don't re-evaluate container.size() all the time (II)
Experience shows that the compiler does not recognize the
size() call as a constant expression, so help it along.
Change-Id: I688244f37c555365566cd1a59dc601974316a2e6
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Diffstat (limited to 'src/gui/image')
-rw-r--r-- | src/gui/image/qiconloader.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/gui/image/qiconloader.cpp b/src/gui/image/qiconloader.cpp index 88f505cc39..004cd7493f 100644 --- a/src/gui/image/qiconloader.cpp +++ b/src/gui/image/qiconloader.cpp @@ -447,8 +447,10 @@ QIconLoaderEngineEntry *QIconLoaderEngine::entryForSize(const QSize &size) // Note that m_entries are sorted so that png-files // come first + const int numEntries = m_entries.size(); + // Search for exact matches first - for (int i = 0; i < m_entries.count(); ++i) { + for (int i = 0; i < numEntries; ++i) { QIconLoaderEngineEntry *entry = m_entries.at(i); if (directoryMatchesSize(entry->dir, iconsize)) { return entry; @@ -458,7 +460,7 @@ QIconLoaderEngineEntry *QIconLoaderEngine::entryForSize(const QSize &size) // Find the minimum distance icon int minimalSize = INT_MAX; QIconLoaderEngineEntry *closestMatch = 0; - for (int i = 0; i < m_entries.count(); ++i) { + for (int i = 0; i < numEntries; ++i) { QIconLoaderEngineEntry *entry = m_entries.at(i); int distance = directorySizeDistance(entry->dir, iconsize); if (distance < minimalSize) { |