summaryrefslogtreecommitdiffstats
path: root/src/gui/kernel/qplatformwindow.cpp
diff options
context:
space:
mode:
authorMiikka Heikkinen <miikka.heikkinen@digia.com>2012-09-13 12:14:13 +0300
committerThe Qt Project <gerrit-noreply@qt-project.org>2012-09-18 14:52:38 +0200
commitede4f5e23b08e9b2cc8fb6a449ee9f667b8da9fa (patch)
tree11175bab8835c6f40faed5afd8b57b41b3a1716f /src/gui/kernel/qplatformwindow.cpp
parentbeab941e1fc11c8fe0914c6a3207ba029eb96112 (diff)
Fix mapping to/from global coordinates for child/embedded windows.
QWidget's mapToGlobal() and mapFromGlobal() functions assumed that if the widget reports it's a window or if it has no parent widget, it must be a top level window whose coordinates are in global coordinates. This is not true for child QWindows or embedded native windows (QAxWidgets). Changed the logic for mapping coordinates to use equivalent methods from QWindow if widget has a window handle, and changed QWindow's methods to map coordinates using native methods if window is embedded. Also fixed newly failing accessibility autotest. The geometry related failures there popped up because now the position of the rect returned by accessible interface is actually correct while widget geometry still reports position 0,0 before widget has shown up. Task-number: QTBUG-26436 Change-Id: I658fafd0ce01eb1604ba255efeeba3073ca0189f Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
Diffstat (limited to 'src/gui/kernel/qplatformwindow.cpp')
-rw-r--r--src/gui/kernel/qplatformwindow.cpp24
1 files changed, 24 insertions, 0 deletions
diff --git a/src/gui/kernel/qplatformwindow.cpp b/src/gui/kernel/qplatformwindow.cpp
index 748a7825b6..6200ad01bf 100644
--- a/src/gui/kernel/qplatformwindow.cpp
+++ b/src/gui/kernel/qplatformwindow.cpp
@@ -188,6 +188,30 @@ bool QPlatformWindow::isEmbedded(const QPlatformWindow *parentWindow) const
}
/*!
+ Translates the window coordinate \a pos to global screen
+ coordinates using native methods. This is required for embedded windows,
+ where the topmost QWindow coordinates are not global screen coordinates.
+
+ Returns \a pos if there is no platform specific implementation.
+*/
+QPoint QPlatformWindow::mapToGlobal(const QPoint &pos) const
+{
+ return pos;
+}
+
+/*!
+ Translates the global screen coordinate \a pos to window
+ coordinates using native methods. This is required for embedded windows,
+ where the topmost QWindow coordinates are not global screen coordinates.
+
+ Returns \a pos if there is no platform specific implementation.
+*/
+QPoint QPlatformWindow::mapFromGlobal(const QPoint &pos) const
+{
+ return pos;
+}
+
+/*!
Requests setting the window state of this surface
to \a type. Returns the actual state set.