path: root/src/gui/kernel/qstylehints.cpp
diff options
authorMarc Mutz <>2015-10-17 17:48:34 +0200
committerMarc Mutz <>2016-03-04 10:29:08 +0000
commit600529e07a46d8e20f4302dc988125f3fee36ec4 (patch)
treed1ef58c493d6f9dd2521c63ce1f07e04a7aa5658 /src/gui/kernel/qstylehints.cpp
parentb6b3803b213787a04dfc7542caeb541a5535d90f (diff)
QtGui: use printf-style qWarning/qDebug where possible (I)
The printf-style version of QDebug expands to a lot less code than the std::ostream-style version. Of course, you pay in type safety (but compilers warn about it these days), you cannot stream complex Qt types and streaming QStrings is awkward, but in many cases you actually improve on readability. But the main reason is that something that's not supposed to be executed under normal operation has no business bloating executable code size. This is not an attempt at converting all qWarnings() to printf-style, only the low-hanging fruit. In this first part, replace qWarning() << "..."; with qWarning("..."); In QTransform shared warning strings. Saves 3KiB in text size on optimized GCC 5.3 AMD64 builds. Change-Id: I142a8020eaab043d78465178192f2c8c6d1cc4f9 Reviewed-by: Friedemann Kleint <> Reviewed-by: Kai Koehne <>
Diffstat (limited to 'src/gui/kernel/qstylehints.cpp')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/kernel/qstylehints.cpp b/src/gui/kernel/qstylehints.cpp
index e184fed275..ecc2886a04 100644
--- a/src/gui/kernel/qstylehints.cpp
+++ b/src/gui/kernel/qstylehints.cpp
@@ -54,7 +54,7 @@ static inline QVariant themeableHint(QPlatformTheme::ThemeHint th,
QPlatformIntegration::StyleHint ih)
if (!QCoreApplication::instance()) {
- qWarning() << "Must construct a QGuiApplication before accessing a platform theme hint.";
+ qWarning("Must construct a QGuiApplication before accessing a platform theme hint.");
return QVariant();
if (const QPlatformTheme *theme = QGuiApplicationPrivate::platformTheme()) {