path: root/src/gui/text/qfontengine_ft.cpp
diff options
authorMarc Mutz <>2016-03-05 11:21:02 +0100
committerMarc Mutz <>2016-03-05 12:02:47 +0000
commitec29c76e18f3a30e559e9eb31dfcc20b80b9522c (patch)
tree32e8826b8919f912e9d757c97a77076089f9db23 /src/gui/text/qfontengine_ft.cpp
parentd5fde514106f5479f9c929c8a165aced4a1b2c84 (diff)
Fix UB in QFontEngineFT::loadGlyph()
Reported by UBSan: src/gui/text/qfontengine_ft.cpp:1079:54: runtime error: null pointer passed as argument 1, which is declared to never be null The default-constructed QScopedArrayPointer is not reset() in every code path. In fact, in the code path leading to this memset, the only reset() call is in the if block right above it, so move the memset into the if block. Change-Id: I1f793c313ca56f3315c6bdd55456cb025cafc089 Reviewed-by: Konstantin Ritt <>
Diffstat (limited to 'src/gui/text/qfontengine_ft.cpp')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/text/qfontengine_ft.cpp b/src/gui/text/qfontengine_ft.cpp
index 0a0e174343..8fbeff3596 100644
--- a/src/gui/text/qfontengine_ft.cpp
+++ b/src/gui/text/qfontengine_ft.cpp
@@ -1073,8 +1073,8 @@ QFontEngineFT::Glyph *QFontEngineFT::loadGlyph(QGlyphSet *set, uint glyph,
if (glyph_buffer_size < pitch * info.height) {
glyph_buffer_size = pitch * info.height;
glyph_buffer.reset(new uchar[glyph_buffer_size]);
+ memset(, 0, glyph_buffer_size);
- memset(, 0, glyph_buffer_size);
if (slot->format == FT_GLYPH_FORMAT_OUTLINE) {
FT_Bitmap bitmap;