path: root/src/gui/text/qtextdocument_p.cpp
diff options
authorMarc Mutz <>2016-02-16 15:24:38 +0100
committerMarc Mutz <>2016-02-29 07:57:47 +0000
commita7885c9756d423042bd0670d82d78d8dffe9be54 (patch)
tree913f0db5b4ef655c6d708781e7de5a352e5c5043 /src/gui/text/qtextdocument_p.cpp
parent85c2a128ef8d1b5fbddf551691bccc0770e558ba (diff)
QVector: preserve capacity in clear()
This is what std::vector implementations usually do, because it minimizes memory fragmentation and useless allocations since no user will call clear() unless she intends to append new data afterwards. Fix calls to resize(0) that show how existing code tried to work around the issue. Adjust test. Port from QVERIFY(==) to QCOMPARE as a drive-by. [ChangeLog][QtCore][QVector] clear() now preserves capacity. To shed capacity, call squeeze() or swap with a default-constructed QVector object, see the documentation for an example. Change-Id: I9cebe611a97e027a89e821e64408a4741b31f1f6 Reviewed-by: Lars Knoll <>
Diffstat (limited to 'src/gui/text/qtextdocument_p.cpp')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/text/qtextdocument_p.cpp b/src/gui/text/qtextdocument_p.cpp
index 348fa83756..93071aaf59 100644
--- a/src/gui/text/qtextdocument_p.cpp
+++ b/src/gui/text/qtextdocument_p.cpp
@@ -1128,7 +1128,7 @@ void QTextDocumentPrivate::clearUndoRedoStacks(QTextDocument::Stacks stacksToCle
delete c.custom;
undoState = 0;
- undoStack.resize(0);
+ undoStack.clear();
if (emitSignals && undoCommandsAvailable)
if (emitSignals && redoCommandsAvailable)