path: root/src/gui/util
diff options
authorMarc Mutz <>2014-10-08 11:35:24 +0200
committerMarc Mutz <>2014-10-09 09:42:00 +0200
commit1a5c0b26d062a380fef1bb038a9d96cde7556dc6 (patch)
tree10f36942a89365b0bea350dab8041801514a2495 /src/gui/util
parentbf1df558461f21827eaad9d5d9541def784980a2 (diff)
Don't use QStringLiteral in comparisons
For QLatin1String, operator== is overloaded, so comparing to a latin-1 (C) string literal is efficient, since strlen() is comparatively fast. OTOH, QStringLiteral, when not using RVO, litters the code with QString dtor calls, which are not inline. Worse, absent lambdas, it even allocates memory. So, just compare using QLatin1String instead. Change-Id: I7af3bf3a67c55dae33ffaf9922d004fa168a3f9c Reviewed-by: Thiago Macieira <>
Diffstat (limited to 'src/gui/util')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/util/qdesktopservices.cpp b/src/gui/util/qdesktopservices.cpp
index eec9272aa1..60f9096a77 100644
--- a/src/gui/util/qdesktopservices.cpp
+++ b/src/gui/util/qdesktopservices.cpp
@@ -190,7 +190,7 @@ bool QDesktopServices::openUrl(const QUrl &url)
qWarning("%s: The platform plugin does not support services.", Q_FUNC_INFO);
return false;
- return url.scheme() == QStringLiteral("file") ?
+ return url.scheme() == QLatin1String("file") ?
platformServices->openDocument(url) : platformServices->openUrl(url);