diff options
| author | Robert Loehning <robert.loehning@qt.io> | 2020-07-08 20:42:57 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2020-07-24 10:12:43 +0000 |
| commit | ccaaeaad62672db118782055244a21795c410407 (patch) | |
| tree | cdb33443d4f993c381561c2b372d1499db0635d0 /src/gui | |
| parent | e748b6a524d450a02749868ff2e37f4eb05293f1 (diff) | |
Multiply instead of shifting
The shift operator is undefined for negative values.
Fixes: oss-fuzz-23735
Change-Id: Ib4bad0bf2135f9ddc95f6d7de64d935a02b4791e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit fd0c9fcaccbbb284f00c3403152bd3faf5940888)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/gui')
| -rw-r--r-- | src/gui/painting/qcosmeticstroker.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/painting/qcosmeticstroker.cpp b/src/gui/painting/qcosmeticstroker.cpp index 9012119516..b636f0739d 100644 --- a/src/gui/painting/qcosmeticstroker.cpp +++ b/src/gui/painting/qcosmeticstroker.cpp @@ -474,7 +474,7 @@ void QCosmeticStroker::calculateLastPoint(qreal rx1, qreal ry1, qreal rx2, qreal qSwap(y1, y2); } int yinc = F16Dot16FixedDiv(y2 - y1, x2 - x1); - int y = y1 << 10; + int y = y1 * (1 << 10); int x = (x1 + 32) >> 6; int xs = (x2 + 32) >> 6; |