diff options
author | Sergio Ahumada <sergio.ahumada@nokia.com> | 2012-09-08 19:08:53 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-09-14 15:23:15 +0200 |
commit | 0a37bcf24547101595299572533e5e3a98e04e1d (patch) | |
tree | 015338f188df67ebdfe4a5ab7c2fd8fc84251be7 /src/gui | |
parent | 26b6cce44bc4fb81b09420bdaf56fc6036d1eece (diff) |
Mark (non-public API's) ctor's as explicit
Make C++ class constructors that can be used with only one
required argument 'explicit' to minimize wrong use of the class.
Change-Id: I12ad5b6eb1794108c6b7464a2573e84068733b03
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/gui')
-rw-r--r-- | src/gui/painting/qpathclipper_p.h | 2 | ||||
-rw-r--r-- | src/gui/text/qcssparser_p.h | 2 | ||||
-rw-r--r-- | src/gui/text/qfontsubset_p.h | 2 | ||||
-rw-r--r-- | src/gui/text/qzipreader_p.h | 2 | ||||
-rw-r--r-- | src/gui/text/qzipwriter_p.h | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/src/gui/painting/qpathclipper_p.h b/src/gui/painting/qpathclipper_p.h index 85b66a1515..8d1170dd9e 100644 --- a/src/gui/painting/qpathclipper_p.h +++ b/src/gui/painting/qpathclipper_p.h @@ -137,7 +137,7 @@ public: Curve }; - QPathEdge(int a = -1, int b = -1); + explicit QPathEdge(int a = -1, int b = -1); mutable int flag; diff --git a/src/gui/text/qcssparser_p.h b/src/gui/text/qcssparser_p.h index 0dc4438d04..826e0b309d 100644 --- a/src/gui/text/qcssparser_p.h +++ b/src/gui/text/qcssparser_p.h @@ -752,7 +752,7 @@ class Q_GUI_EXPORT Parser { public: Parser(); - Parser(const QString &css, bool file = false); + explicit Parser(const QString &css, bool file = false); void init(const QString &css, bool file = false); bool parse(StyleSheet *styleSheet, Qt::CaseSensitivity nameCaseSensitivity = Qt::CaseSensitive); diff --git a/src/gui/text/qfontsubset_p.h b/src/gui/text/qfontsubset_p.h index a120a18d3a..3607b0189c 100644 --- a/src/gui/text/qfontsubset_p.h +++ b/src/gui/text/qfontsubset_p.h @@ -60,7 +60,7 @@ QT_BEGIN_NAMESPACE class QFontSubset { public: - QFontSubset(QFontEngine *fe, int obj_id = 0) + explicit QFontSubset(QFontEngine *fe, int obj_id = 0) : object_id(obj_id), noEmbed(false), fontEngine(fe), downloaded_glyphs(0), standard_font(false) { fontEngine->ref.ref(); addGlyph(0); } ~QFontSubset() { diff --git a/src/gui/text/qzipreader_p.h b/src/gui/text/qzipreader_p.h index 7783c5bba3..06356cd6ab 100644 --- a/src/gui/text/qzipreader_p.h +++ b/src/gui/text/qzipreader_p.h @@ -66,7 +66,7 @@ class QZipReaderPrivate; class Q_GUI_EXPORT QZipReader { public: - QZipReader(const QString &fileName, QIODevice::OpenMode mode = QIODevice::ReadOnly ); + explicit QZipReader(const QString &fileName, QIODevice::OpenMode mode = QIODevice::ReadOnly ); explicit QZipReader(QIODevice *device); ~QZipReader(); diff --git a/src/gui/text/qzipwriter_p.h b/src/gui/text/qzipwriter_p.h index 5fcc48a10b..556699a62f 100644 --- a/src/gui/text/qzipwriter_p.h +++ b/src/gui/text/qzipwriter_p.h @@ -64,7 +64,7 @@ class QZipWriterPrivate; class Q_GUI_EXPORT QZipWriter { public: - QZipWriter(const QString &fileName, QIODevice::OpenMode mode = (QIODevice::WriteOnly | QIODevice::Truncate) ); + explicit QZipWriter(const QString &fileName, QIODevice::OpenMode mode = (QIODevice::WriteOnly | QIODevice::Truncate) ); explicit QZipWriter(QIODevice *device); ~QZipWriter(); |