diff options
author | Shane Kearns <ext-shane.2.kearns@nokia.com> | 2012-05-31 16:09:38 +0100 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-06-01 15:19:42 +0200 |
commit | bae1613c4c3d8c38b90ed2ba5c1b149e1bc87987 (patch) | |
tree | cb7d38a1a0cb1ca84e7558f374ff2bb29d68a1fa /src/network/access/qnetworkaccessmanager_p.h | |
parent | 3580168c3e357c2289acddc5f2515a3ad306ef2b (diff) |
QNAM - maintain a weak reference to the QNetworkSession
When handling signals from the session, a pointer is needed.
Also the QNetworkReplyImpl needs to access the manager's session.
So, the manager should have a strong and weak reference.
The strong reference is held during connection establishment.
The weak reference is held all the time, though it will become
null when the session is destroyed in idle.
The non static member function getNetworkSession() is used to
create strong references from the weak reference where required.
Task-number: ou1cimx#1004278
Change-Id: I4b5b36b1d996b98e659d993969006c61b4440c15
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
Diffstat (limited to 'src/network/access/qnetworkaccessmanager_p.h')
-rw-r--r-- | src/network/access/qnetworkaccessmanager_p.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/network/access/qnetworkaccessmanager_p.h b/src/network/access/qnetworkaccessmanager_p.h index bd3dc3953d..94238db246 100644 --- a/src/network/access/qnetworkaccessmanager_p.h +++ b/src/network/access/qnetworkaccessmanager_p.h @@ -78,7 +78,6 @@ public: proxyFactory(0), #endif #ifndef QT_NO_BEARERMANAGEMENT - networkSession(0), lastSessionState(QNetworkSession::Invalid), networkAccessible(QNetworkAccessManager::Accessible), activeReplyCount(0), @@ -120,6 +119,7 @@ public: #ifndef QT_NO_BEARERMANAGEMENT void createSession(const QNetworkConfiguration &config); + QSharedPointer<QNetworkSession> getNetworkSession() const; void _q_networkSessionClosed(); void _q_networkSessionNewConfigurationActivated(); @@ -144,7 +144,8 @@ public: #endif #ifndef QT_NO_BEARERMANAGEMENT - QSharedPointer<QNetworkSession> networkSession; + QSharedPointer<QNetworkSession> networkSessionStrongRef; + QWeakPointer<QNetworkSession> networkSessionWeakRef; QNetworkSession::State lastSessionState; QString networkConfiguration; QNetworkAccessManager::NetworkAccessibility networkAccessible; |