diff options
| author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-01-23 13:05:12 +0400 |
|---|---|---|
| committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-02-13 16:29:16 +0000 |
| commit | 9b67d89c24666d405dd00e63bb56c924738aa002 (patch) | |
| tree | bf0c0197b68097e9aace8ac3708dcbf0e3fe0c7c /src/network/access | |
| parent | 22b5c39e8e0f4d8cb8a2b2d661e0451e01b75929 (diff) | |
Pass params of shareable type by const-ref rather than by value
...where passing them by value was not intentional.
Change-Id: Ifd5036d57b41fddeeacfbd3f5890881605b80647
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/network/access')
| -rw-r--r-- | src/network/access/qftp.cpp | 8 | ||||
| -rw-r--r-- | src/network/access/qnetworkcookiejar.cpp | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/network/access/qftp.cpp b/src/network/access/qftp.cpp index badcb5b021..bb89eece4b 100644 --- a/src/network/access/qftp.cpp +++ b/src/network/access/qftp.cpp @@ -225,8 +225,8 @@ private: class QFtpCommand { public: - QFtpCommand(QFtp::Command cmd, QStringList raw, const QByteArray &ba); - QFtpCommand(QFtp::Command cmd, QStringList raw, QIODevice *dev = 0); + QFtpCommand(QFtp::Command cmd, const QStringList &raw, const QByteArray &ba); + QFtpCommand(QFtp::Command cmd, const QStringList &raw, QIODevice *dev = 0); ~QFtpCommand(); int id; @@ -246,14 +246,14 @@ public: QBasicAtomicInt QFtpCommand::idCounter = Q_BASIC_ATOMIC_INITIALIZER(1); -QFtpCommand::QFtpCommand(QFtp::Command cmd, QStringList raw, const QByteArray &ba) +QFtpCommand::QFtpCommand(QFtp::Command cmd, const QStringList &raw, const QByteArray &ba) : command(cmd), rawCmds(raw), is_ba(true) { id = idCounter.fetchAndAddRelaxed(1); data.ba = new QByteArray(ba); } -QFtpCommand::QFtpCommand(QFtp::Command cmd, QStringList raw, QIODevice *dev) +QFtpCommand::QFtpCommand(QFtp::Command cmd, const QStringList &raw, QIODevice *dev) : command(cmd), rawCmds(raw), is_ba(false) { id = idCounter.fetchAndAddRelaxed(1); diff --git a/src/network/access/qnetworkcookiejar.cpp b/src/network/access/qnetworkcookiejar.cpp index f5c97aeaae..3cefb28f68 100644 --- a/src/network/access/qnetworkcookiejar.cpp +++ b/src/network/access/qnetworkcookiejar.cpp @@ -130,7 +130,7 @@ void QNetworkCookieJar::setAllCookies(const QList<QNetworkCookie> &cookieList) d->allCookies = cookieList; } -static inline bool isParentPath(QString path, QString reference) +static inline bool isParentPath(const QString &path, const QString &reference) { if (path.startsWith(reference)) { //The cookie-path and the request-path are identical. @@ -149,7 +149,7 @@ static inline bool isParentPath(QString path, QString reference) return false; } -static inline bool isParentDomain(QString domain, QString reference) +static inline bool isParentDomain(const QString &domain, const QString &reference) { if (!reference.startsWith(QLatin1Char('.'))) return domain == reference; |