Port from container.count()/length() to size()

This is semantic patch using ClangTidyTransformator:

  auto QtContainerClass = expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)
  makeRule(cxxMemberCallExpr(on(QtContainerClass),
                             callee(cxxMethodDecl(hasAnyName({"count", "length"),
                                                  parameterCountIs(0))))),
           changeTo(cat(access(o, cat("size"), "()"))),
           cat("use 'size()' instead of 'count()/length()'"))

a.k.a qt-port-to-std-compatible-api with config Scope: 'Container'.

<classes> are:

    // sequential:
    "QByteArray",
    "QList",
    "QQueue",
    "QStack",
    "QString",
    "QVarLengthArray",
    "QVector",
    // associative:
    "QHash",
    "QMultiHash",
    "QMap",
    "QMultiMap",
    "QSet",
    // Qt has no QMultiSet

Change-Id: Ibe8837be96e8d30d1846881ecd65180c1bc459af
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>

4 files changed, 13 insertions, 13 deletions

diff --git a/src/network/kernel/qauthenticator.cpp b/src/network/kernel/qauthenticator.cpp
index 4b9ed021be..9e5f48c456 100644
--- a/src/network/kernel/qauthenticator.cpp
+++ b/src/network/kernel/qauthenticator.cpp
@@ -798,7 +798,7 @@ QByteArray QAuthenticatorPrivate::digestMd5Response(QByteArrayView challenge, QB
 
     ++nonceCount;
     QByteArray nonceCountString = QByteArray::number(nonceCount, 16);
-    while (nonceCountString.length() < 8)
+    while (nonceCountString.size() < 8)
         nonceCountString.prepend('0');
 
     QByteArray nonce = options.value("nonce");
@@ -1079,7 +1079,7 @@ static int qEncodeNtlmString(QNtlmBuffer& buf, int offset, const QString& s, boo
 {
     if (!unicode)
         return qEncodeNtlmBuffer(buf, offset, s.toLatin1());
-    buf.len = 2 * s.length();
+    buf.len = 2 * s.size();
     buf.maxLen = buf.len;
     buf.offset = (offset + 1) & ~1;
     return buf.offset + buf.len;
@@ -1201,7 +1201,7 @@ static QByteArray qNtlmPhase1()
 
 static QByteArray qStringAsUcs2Le(const QString& src)
 {
-    QByteArray rc(2*src.length(), 0);
+    QByteArray rc(2*src.size(), 0);
     unsigned short *d = (unsigned short*)rc.data();
     for (QChar ch : src)
         *d++ = qToLittleEndian(quint16(ch.unicode()));
@@ -1214,7 +1214,7 @@ static QString qStringFromUcs2Le(QByteArray src)
 {
     Q_ASSERT(src.size() % 2 == 0);
     unsigned short *d = (unsigned short*)src.data();
-    for (int i = 0; i < src.length() / 2; ++i) {
+    for (int i = 0; i < src.size() / 2; ++i) {
         d[i] = qFromLittleEndian(d[i]);
     }
     return QString((const QChar *)src.data(), src.size()/2);
@@ -1256,7 +1256,7 @@ QByteArray qEncodeHmacMd5(QByteArray &key, QByteArrayView message)
     hash.reset();
     // Adjust the key length to blockSize
 
-    if (blockSize < key.length()) {
+    if (blockSize < key.size()) {
         hash.addData(key);
         key = hash.result(); //MD5 will always return 16 bytes length output
     }
diff --git a/src/network/kernel/qhostaddress.cpp b/src/network/kernel/qhostaddress.cpp
index 8fb321bf20..2f673d8c6d 100644
--- a/src/network/kernel/qhostaddress.cpp
+++ b/src/network/kernel/qhostaddress.cpp
@@ -1054,14 +1054,14 @@ QPair<QHostAddress, int> QHostAddress::parseSubnet(const QString &subnet)
 
     // parse the address manually
     auto parts = netStr.split(u'.');
-    if (parts.isEmpty() || parts.count() > 4)
+    if (parts.isEmpty() || parts.size() > 4)
         return invalid;         // invalid IPv4 address
 
     if (parts.constLast().isEmpty())
         parts.removeLast();
 
     quint32 addr = 0;
-    for (int i = 0; i < parts.count(); ++i) {
+    for (int i = 0; i < parts.size(); ++i) {
         bool ok;
         uint byteValue = parts.at(i).toUInt(&ok);
         if (!ok || byteValue > 255)
@@ -1070,9 +1070,9 @@ QPair<QHostAddress, int> QHostAddress::parseSubnet(const QString &subnet)
         addr <<= 8;
         addr += byteValue;
     }
-    addr <<= 8 * (4 - parts.count());
+    addr <<= 8 * (4 - parts.size());
     if (netmask == -1) {
-        netmask = 8 * parts.count();
+        netmask = 8 * parts.size();
     } else if (netmask == 0) {
         // special case here
         // x86's instructions "shr" and "shl" do not operate when
diff --git a/src/network/kernel/qhostinfo.cpp b/src/network/kernel/qhostinfo.cpp
index ae0fde0643..2283766b97 100644
--- a/src/network/kernel/qhostinfo.cpp
+++ b/src/network/kernel/qhostinfo.cpp
@@ -934,7 +934,7 @@ void QHostInfoLookupManager::rescheduleWithMutexHeld()
 
     if (!finishedLookups.isEmpty()) {
         // remove ID from aborted if it is in there
-        for (int i = 0; i < finishedLookups.length(); i++) {
+        for (int i = 0; i < finishedLookups.size(); i++) {
            abortedLookups.removeAll(finishedLookups.at(i)->id);
         }
 
@@ -1002,7 +1002,7 @@ void QHostInfoLookupManager::abortLookup(int id)
 
 #if QT_CONFIG(thread)
     // is postponed? delete and return
-    for (int i = 0; i < postponedLookups.length(); i++) {
+    for (int i = 0; i < postponedLookups.size(); i++) {
         if (postponedLookups.at(i)->id == id) {
             delete postponedLookups.takeAt(i);
             return;
@@ -1011,7 +1011,7 @@ void QHostInfoLookupManager::abortLookup(int id)
 #endif
 
     // is scheduled? delete and return
-    for (int i = 0; i < scheduledLookups.length(); i++) {
+    for (int i = 0; i < scheduledLookups.size(); i++) {
         if (scheduledLookups.at(i)->id == id) {
             delete scheduledLookups.takeAt(i);
             return;
diff --git a/src/network/kernel/qnetworkinterface_linux.cpp b/src/network/kernel/qnetworkinterface_linux.cpp
index 4c92e01c23..51fb23b547 100644
--- a/src/network/kernel/qnetworkinterface_linux.cpp
+++ b/src/network/kernel/qnetworkinterface_linux.cpp
@@ -186,7 +186,7 @@ void processNetlinkRequest(int sock, struct nlmsghdr *hdr, char *buf, size_t buf
 uint QNetworkInterfaceManager::interfaceIndexFromName(const QString &name)
 {
     uint index = 0;
-    if (name.length() >= IFNAMSIZ)
+    if (name.size() >= IFNAMSIZ)
         return index;
 
     int socket = qt_safe_socket(AF_INET, SOCK_DGRAM, 0);