diff options
| author | Alex Trotsenko <alex1973tr@gmail.com> | 2016-04-01 13:19:10 +0300 |
|---|---|---|
| committer | Alex Trotsenko <alex1973tr@gmail.com> | 2016-04-07 11:45:41 +0000 |
| commit | ccb693299e6ef633d3ac330961c872a03815c93c (patch) | |
| tree | f9f4c5835cbaa2189504d33b95a3ea4ffee08032 /src/network/socket/qabstractsocket_p.h | |
| parent | 115d4fc8cc1816d70f41c839d7eaa4e24ff86db2 (diff) | |
Rework toggling the state of read notifier on unbuffered socket
To avoid infinite loop on unbuffered socket, previous implementation
always disabled the read notifications before emitting a readyRead()
signal. So, it's very likely that the socket will toggle the state of
notifier twice (on->off->on) in one notification cycle.
This patch prevents this unnecessary toggling by deferring the
notification disabling in canReadNotification() to the next
notification cycle.
Change-Id: Iebc5a7ad18a6f40ea1cf63e7f1b12f6c180cbf7a
Reviewed-by: Markus Goetz (Woboq GmbH) <markus@woboq.com>
Diffstat (limited to 'src/network/socket/qabstractsocket_p.h')
| -rw-r--r-- | src/network/socket/qabstractsocket_p.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/network/socket/qabstractsocket_p.h b/src/network/socket/qabstractsocket_p.h index ab642e039b..3164c96c1e 100644 --- a/src/network/socket/qabstractsocket_p.h +++ b/src/network/socket/qabstractsocket_p.h @@ -143,6 +143,7 @@ public: qint64 readBufferMaxSize; bool isBuffered; + bool hasPendingData; QTimer *connectTimer; QTimer *disconnectTimer; |