diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2015-03-05 23:40:29 -0800 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@intel.com> | 2015-03-07 21:32:41 +0000 |
| commit | 1cd8d67d5f9bb0cd17147481544db8fb9342354d (patch) | |
| tree | 902e89b2cad1844194c1867ad6a2d86c21efc200 /src/network | |
| parent | 53ce0d1a31c8ebb54952887b8bcf769843d50d9c (diff) | |
Fix NTLM possible data corruption
A mistake in const correctness resulted in the incoming QByteArray
getting modified when it shouldn't. I have no ldea if this could result
in user-visible effects.
Change-Id: Ia0aac2f09e9245339951ffff13c8d8c6b4f909bd
Reviewed-by: Richard J. Moore <rich@kde.org>
Diffstat (limited to 'src/network')
| -rw-r--r-- | src/network/kernel/qauthenticator.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/network/kernel/qauthenticator.cpp b/src/network/kernel/qauthenticator.cpp index d31c04eb87..abb47e9e29 100644 --- a/src/network/kernel/qauthenticator.cpp +++ b/src/network/kernel/qauthenticator.cpp @@ -1078,7 +1078,7 @@ static QByteArray qStringAsUcs2Le(const QString& src) } -static QString qStringFromUcs2Le(const QByteArray& src) +static QString qStringFromUcs2Le(QByteArray src) { Q_ASSERT(src.size() % 2 == 0); unsigned short *d = (unsigned short*)src.data(); |