diff options
| author | Mårten Nordheim <marten.nordheim@qt.io> | 2021-02-17 13:59:29 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-02-18 15:45:04 +0000 |
| commit | 34702411617f899517d949e2c83c9dd306ebd43a (patch) | |
| tree | ca9bf670f2a5727cf885d5ac5aac31ec8364775d /src/network | |
| parent | 8fa8f4dab059a5e77313bcc599d421bde40bc4e8 (diff) | |
QNetworkInformation: Address API review feedback
Added missing NOTIFY for Q_PROPERTY.
Switched one Q_ENUM to Q_FLAG.
Declared missing operators for QFlag.
Change-Id: I8e6756838e44e205844a34c95f436df6b51a862f
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 0d4fb41e8c00263a0d385b70cc066776cbf6cc37)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/network')
| -rw-r--r-- | src/network/kernel/qnetworkinformation.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/network/kernel/qnetworkinformation.h b/src/network/kernel/qnetworkinformation.h index a04e725300..bc71b37c64 100644 --- a/src/network/kernel/qnetworkinformation.h +++ b/src/network/kernel/qnetworkinformation.h @@ -53,7 +53,7 @@ class Q_NETWORK_EXPORT QNetworkInformation : public QObject { Q_OBJECT Q_DECLARE_PRIVATE(QNetworkInformation) - Q_PROPERTY(Reachability reachability READ reachability) + Q_PROPERTY(Reachability reachability READ reachability NOTIFY reachabilityChanged) public: enum class Reachability { Unknown, @@ -67,8 +67,8 @@ public: enum class Feature { Reachability = 0x1, }; - Q_ENUM(Feature) Q_DECLARE_FLAGS(Features, Feature) + Q_FLAG(Features) ~QNetworkInformation() override; @@ -93,6 +93,8 @@ private: Q_DISABLE_COPY_MOVE(QNetworkInformation) }; +Q_DECLARE_OPERATORS_FOR_FLAGS(QNetworkInformation::Features) + QT_END_NAMESPACE #endif |