linuxfb: Remove QFbWindow::setVisible

QFbWindow::setVisible doesn't call into the base class implementation
and thus suppresses the delivery of the expose event. It turns out we
don't need to track the visiblity at all since the base QPA code tracks
this already.

After this change, windows are now render on the framebuffer.

Change-Id: Ifcfc730456883eb423d79479bd0b04330b8c2d72
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Thomas Senyk <thomas.senyk@nokia.com>
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>

3 files changed, 2 insertions, 13 deletions

diff --git a/src/platformsupport/fbconvenience/qfbscreen.cpp b/src/platformsupport/fbconvenience/qfbscreen.cpp
index a5ac0a37d4..b6261d7280 100644
--- a/src/platformsupport/fbconvenience/qfbscreen.cpp
+++ b/src/platformsupport/fbconvenience/qfbscreen.cpp
@@ -201,7 +201,7 @@ QRegion QFbScreen::doRedraw()
                 }
 
                 for (int layerIndex = layer; layerIndex != -1; layerIndex--) {
-                    if (!mWindowStack[layerIndex]->isVisible())
+                    if (!mWindowStack[layerIndex]->window()->isVisible())
                         continue;
                     // if (mWindowStack[layerIndex]->isMinimized())
                     //     continue;
diff --git a/src/platformsupport/fbconvenience/qfbwindow.cpp b/src/platformsupport/fbconvenience/qfbwindow.cpp
index 74e9c0afcd..625a63fe79 100644
--- a/src/platformsupport/fbconvenience/qfbwindow.cpp
+++ b/src/platformsupport/fbconvenience/qfbwindow.cpp
@@ -47,7 +47,7 @@
 QT_BEGIN_NAMESPACE
 
 QFbWindow::QFbWindow(QWindow *window)
-    : QPlatformWindow(window), mBackingStore(0), mVisible(false)
+    : QPlatformWindow(window), mBackingStore(0)
 {
     static QAtomicInt winIdGenerator(1);
     mWindowId = winIdGenerator.fetchAndAddRelaxed(1);
@@ -76,13 +76,6 @@ void QFbWindow::setGeometry(const QRect &rect)
     QPlatformWindow::setGeometry(rect);
 }
 
-void QFbWindow::setVisible(bool visible)
-{
-    mVisible = visible;
-    platformScreen()->invalidateRectCache();
-    platformScreen()->setDirty(geometry());
-}
-
 Qt::WindowFlags QFbWindow::setWindowFlags(Qt::WindowFlags flags)
 {
     mWindowFlags = flags;
diff --git a/src/platformsupport/fbconvenience/qfbwindow_p.h b/src/platformsupport/fbconvenience/qfbwindow_p.h
index 333d0fcd4b..a818b5a25f 100644
--- a/src/platformsupport/fbconvenience/qfbwindow_p.h
+++ b/src/platformsupport/fbconvenience/qfbwindow_p.h
@@ -55,9 +55,6 @@ public:
     QFbWindow(QWindow *window);
     ~QFbWindow();
 
-    virtual void setVisible(bool visible);
-    virtual bool isVisible() { return mVisible; }
-
     virtual void raise();
     virtual void lower();
 
@@ -80,7 +77,6 @@ protected:
 
     QFbBackingStore *mBackingStore;
     QRect mOldGeometry;
-    bool mVisible;
     Qt::WindowFlags mWindowFlags;
 
     WId mWindowId;